Skip to contentSkip to conversation

app/test-cmdline: add test to Windows build

PATCH Superseded Andre Muezerie 3 participants 4 messages Dec 23, 2024 – Aug 29, 2025 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/test-cmdline: add test to Windows build

Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences.

---
 app/test-cmdline/cmdline_test.c | 1 -
 app/test-cmdline/commands.c     | 1 -
 app/test-cmdline/meson.build    | 6 ------
 3 files changed, 8 deletions(-)
app/test-cmdline/cmdline_test.c +0 -1
index 89f4260cbf..21b4a4278d 100644
@@ -8,7 +8,6 @@
 #include <stdarg.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <termios.h>
 #include <ctype.h>
 #include <sys/queue.h>
 
app/test-cmdline/commands.c +0 -1
index a13e1d1afd..62b4e5dfa7 100644
@@ -4,7 +4,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <termios.h>
 #include <inttypes.h>
 
 #include <rte_common.h>
app/test-cmdline/meson.build +0 -6
index 6027f67919..9d0a9aeb6e 100644
@@ -1,11 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('commands.c', 'cmdline_test.c')
 deps += 'cmdline'
Signature · 1 line
2.47.0.vfs.0.3
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Mon, 23 Dec 2024 11:35:41 -0800 Andre Muezerie…

From: Andre Muezerie <[email protected]> To:
Cc: [email protected], Andre Muezerie <[email protected]>
Subject: [PATCH] app/test-cmdline: add test to Windows build
Date: Mon, 23 Dec 2024 11:35:41 -0800
X-Mailer: git-send-email 1.8.3.1

Quoted 8 lines

Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences.

---

#2 lore raw

PATCH v2 1/1 app/test-cmdline: add test to Windows build

In reply to Andre Muezerie

Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences.

---
 app/test-cmdline/cmdline_test.c | 1 -
 app/test-cmdline/commands.c     | 1 -
 app/test-cmdline/meson.build    | 6 ------
 3 files changed, 8 deletions(-)
app/test-cmdline/cmdline_test.c +0 -1
index 89f4260cbf..21b4a4278d 100644
@@ -8,7 +8,6 @@
 #include <stdarg.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <termios.h>
 #include <ctype.h>
 #include <sys/queue.h>
 
app/test-cmdline/commands.c +0 -1
index a13e1d1afd..62b4e5dfa7 100644
@@ -4,7 +4,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <termios.h>
 #include <inttypes.h>
 
 #include <rte_common.h>
app/test-cmdline/meson.build +0 -6
index 6027f67919..9d0a9aeb6e 100644
@@ -1,11 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('commands.c', 'cmdline_test.c')
 deps += 'cmdline'
Signature · 1 line
2.50.1.vfs.0.0
#3 lore raw
Quoted 9 lines · Andre Muezerie

Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences.

Applied, thanks.

Signature · 1 line
David Marchand