p7zip recipe broken with rm_work
Hi !
./meta-oe/recipes-extended/p7zip/p7zip_9.20.1.bb
defines:
do_install_class-native() {
install -d ${D}${bindir}
install -d ${D}${bindir}/Codecs
install -m 0755 ${S}/bin/7* ${D}${bindir}
install -m 0755 ${S}/bin/Codecs/* ${D}${bindir}/Codecs
# Create a shell script wrapper to execute next to 7z.so
mv ${D}${bindir}/7z ${D}${bindir}/7z.bin
echo "#! /bin/sh" > ${D}${bindir}/7z
echo "exec ${D}${bindir}/7z.bin \"\$@\"" >> ${D}${bindir}/7z
chmod 0755 ${D}${bindir}/7z
}This wrapper breaks with "rm_work". Shouldn't it use the sysroot ?
Best,
Signature · 3 lines
-- Jan-Simon Möller [email protected]
Quoted 9 lines · Jan-Simon Möller
# Create a shell script wrapper to execute next to 7z.so mv ${D}${bindir}/7z ${D}${bindir}/7z.bin echo "#! /bin/sh" > ${D}${bindir}/7z echo "exec ${D}${bindir}/7z.bin \"\$@\"" >> ${D}${bindir}/7z chmod 0755 ${D}${bindir}/7z }This wrapper breaks with "
rm_work". Shouldn't it use the sysroot ?
Yeah the script should just use ${bindir}, but why is there even a wrapper script?
Ross
Quoted 12 lines · Ross
Quoted 7 lines · Jan-Simon Möller
# Create a shell script wrapper to execute next to 7z.so mv ${D}${bindir}/7z ${D}${bindir}/7z.bin echo "#! /bin/sh" > ${D}${bindir}/7z echo "exec ${D}${bindir}/7z.bin \"\$@\"" >> ${D}${bindir}/7z chmod 0755 ${D}${bindir}/7z }
Quoted 5 lines
Quoted 2 lines
This wrapper breaks with "
rm_work". Shouldn't it use the sysroot ?Yeah the script should just use ${bindir}, but why is there even a wrapper script?
While agreeing on converting the script into a patch, I fail to understand how it it different then some of other install calls in the same function
Quoted 7 lines
Ross
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 3 lines · Khem Raj
While agreeing on converting the script into a patch, I fail to understand how it it different then some of other install calls in the same function
Because the wrapper script will contain ${D} which is inside the work directory.
I just noticed this has already been fixed in master with this commit:
$ git show 67d6ed40bfeb219490e509f33c27ebd2a1149d30 commit 67d6ed40bfeb219490e509f33c27ebd2a1149d30 Author: Jonathan Liu <[email protected]> Date: Fri Sep 23 12:39:24 2016 +1000
p7zip: do not hardcode path in native wrapper script
So if you're using a branch, submit a backport request.
Ross