Skip to contentSkip to conversation

numactl: skip test case when target platform doesn't have 2 CPU node

PATCH Xiangyu Chen 2 participants 2 messages Jan 30, 2023 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · Xiangyu Chen

From: Xiangyu Chen <[email protected]>

when current test platform doesn't have 2 or more CPU node, the test case would report FAIL, according to numa test script and numademo code, when return code=77 should be skip test, so using SKIP instead of FAIL in test script.

Hi Steve,

Friendly ping, this fix has already merged to master and it also can be applied on kirkstone, could you please help to merge it on kirkstone? thanks!

Br,

Xiangyu

Quoted 52 lines
---
  .../numactl/numactl/Fix-the-test-output-format.patch        | 3 ++-
  meta/recipes-support/numactl/numactl/run-ptest              | 6 +++++-
  2 files changed, 7 insertions(+), 2 deletions(-)
meta/recipes-support/numactl/numactl/Fix-the-test-output-format.patch +2 -1
index 9812ecc8b3..a7bc8d322e 100644
@@ -7,6 +7,7 @@ Upstream-Status: Pending
 
  Signed-off-by: Roy Li <[email protected]>
  Signed-off-by: Li Xin <[email protected]>
+Signed-off-by: Xiangyu Chen <[email protected]>
  ---
   test/regress  |  6 +++---
   test/regress2 | 11 +++++------
@@ -20,7 +21,7 @@ index 2ce1705..d086a47 100755
   	if [ $numnodes -lt 2 ] ; then
   	    echo "need at least two nodes with at least $NEEDPAGES each of"
   	    echo "free memory for mempolicy regression tests"
-+	    echo "FAIL: numa regress"
++	    echo "SKIP: numa regress"
  	    exit 77  # Skip test
   	fi
   }
meta/recipes-support/numactl/numactl/run-ptest +5 -2
index bf269da755..e019b0d364 100755
@@ -8,7 +8,11 @@ if ! numactl -s | grep -q "No NUMA support available on this system."; then
  	if  numademo -t -e 10M; then
  		echo "PASS: numademo"
  	else
-		echo "FAIL: numademo"
+		if [ "$?" = 77 ] ; then
+			echo "SKIP: numademo"
+		else
+			echo "FAIL: numademo"
+		fi
  	fi
  else
  	echo "SKIP: ./../test/bind_range"
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#176122): https://lists.openembedded.org/g/openembedded-core/message/176122
Mute This Topic: https://lists.openembedded.org/mt/96372135/7175143
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 10 lines · Xiangyu Chen
Quoted 7 lines · Xiangyu Chen

From: Xiangyu Chen <[email protected]>

when current test platform doesn't have 2 or more CPU node, the test case would report FAIL, according to numa test script and numademo code, when return code=77 should be skip test, so using SKIP instead of FAIL in test script.

Quoted 5 lines
Quoted 1 line

Friendly ping, this fix has already merged to master and it also can be applied on kirkstone, could you please help to merge it on kirkstone? thanks!

This patch is in my current test queue, so if all goes well it will be in the next patchset for both langdale and kirkstone.

Steve