Skip to contentSkip to conversation

RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

PATCH Applied Selvin Xavier 2 participants 2 messages Mar 11, 2025 – Mar 12, 2025

Subsystems (2)
lore
Share & tools
lore

Selvin Xavier

author maintainer
#0 lore raw

PATCH 1/1 RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

From: Saravanan Vajravel <[email protected]>

Driver is always clearing the mask that sets the VLAN ID/Service Level in the adapter. Recent change for supporting multiple traffic class exposed this issue.

Allow setting SL and VLAN_ID while QP is moved from INIT to RTR state.

Fixes 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Fixes c64b16a37b6d ("RDMA/bnxt_re: Support different traffic class")
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/hw/bnxt_re/qplib_fp.c +0 -2
index 5336f74..457eecb 100644
@@ -1217,8 +1217,6 @@ static void __modify_flags_from_init_state(struct bnxt_qplib_qp *qp)
 			qp->path_mtu =
 				CMDQ_MODIFY_QP_PATH_MTU_MTU_2048;
 		}
-		qp->modify_flags &=
-			~CMDQ_MODIFY_QP_MODIFY_MASK_VLAN_ID;
 		/* Bono FW require the max_dest_rd_atomic to be >= 1 */
 		if (qp->max_dest_rd_atomic < 1)
 			qp->max_dest_rd_atomic = 1;
Signature · 1 line
2.5.5
#1 lore raw
Quoted 8 lines · Selvin Xavier

Driver is always clearing the mask that sets the VLAN ID/Service Level in the adapter. Recent change for supporting multiple traffic class exposed this issue.

Allow setting SL and VLAN_ID while QP is moved from INIT to RTR state.

[...]

Applied, thanks!

[1/1] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

      https://git.kernel.org/rdma/rdma/c/81c0db302a674f

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>