Skip to contentSkip to conversation

bbdev: enable to be compiled with MSVC

PATCH Applied Andre Muezerie 2 participants 3 messages Mar 11, 2025 – Mar 12, 2025 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Andre Muezerie

author
#0 lore raw

PATCH 1/1 bbdev: enable to be compiled with MSVC

The errors below popped up when compiling with MSVC:

../lib/bbdev/rte_bbdev.c(79): error C2061:
syntax error: identifier 'TAILQ_ENTRY'
../lib/bbdev/rte_bbdev.c(85): error C2059:
syntax error: '}'

This was caused by a missing include.

Signed-off-by Andre Muezerie <[email protected]>
---
 lib/bbdev/meson.build | 6 ------
 lib/bbdev/rte_bbdev.c | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)
lib/bbdev/meson.build +0 -6
index d8b95a400e..2e48d5f3da 100644
@@ -1,12 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('rte_bbdev.c',
         'bbdev_trace_points.c')
 headers = files('rte_bbdev.h',
lib/bbdev/rte_bbdev.c +1 -0
index d7901cd29d..2c626806f3 100644
@@ -16,6 +16,7 @@
 #include <rte_lcore.h>
 #include <rte_spinlock.h>
 #include <rte_interrupts.h>
+#include <sys/queue.h>
 
 #include "rte_bbdev_op.h"
 #include "rte_bbdev.h"
Signature · 1 line
2.48.1.vfs.0.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 37 lines · Andre Muezerie

The errors below popped up when compiling with MSVC:

../lib/bbdev/rte_bbdev.c(79): error C2061:
syntax error: identifier 'TAILQ_ENTRY'
../lib/bbdev/rte_bbdev.c(85): error C2059:
syntax error: '}'

This was caused by a missing include.

Signed-off-by Andre Muezerie <[email protected]>
---
  lib/bbdev/meson.build | 6 ------
  lib/bbdev/rte_bbdev.c | 1 +
  2 files changed, 1 insertion(+), 6 deletions(-)
lib/bbdev/meson.build +0 -6
index d8b95a400e..2e48d5f3da 100644
@@ -1,12 +1,6 @@
  # SPDX-License-Identifier: BSD-3-Clause
  # Copyright(c) 2017 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
  sources = files('rte_bbdev.c',
          'bbdev_trace_points.c')
  headers = files('rte_bbdev.h',
lib/bbdev/rte_bbdev.c +0 -0
index d7901cd29d..2c626806f3 100644

lib/bbdev/rte_bbdev.c line 19

Quoted 4 lines
lib/bbdev/rte_bbdev.c +1 -0
@@ -16,6 +16,7 @@
  #include <rte_lcore.h>
  #include <rte_spinlock.h>
  #include <rte_interrupts.h>
+#include <sys/queue.h>

It should be included with other general includes, not with RTE ones. I can fix it while applying.

With this fixed:

Reviewed-by Maxime Coquelin <[email protected]>

Thanks,
Maxime

Quoted 3 lines
lib/bbdev/rte_bbdev.c +0 -0
  #include "rte_bbdev_op.h"
  #include "rte_bbdev.h"
Applied
#2 lore raw
Quoted 47 lines · Maxime Coquelin
Quoted 36 lines · Andre Muezerie

The errors below popped up when compiling with MSVC:

../lib/bbdev/rte_bbdev.c(79): error C2061:
     syntax error: identifier 'TAILQ_ENTRY'
../lib/bbdev/rte_bbdev.c(85): error C2059:
     syntax error: '}'

This was caused by a missing include.

Signed-off-by Andre Muezerie <[email protected]>

---
  lib/bbdev/meson.build | 6 ------
  lib/bbdev/rte_bbdev.c | 1 +

  2 files changed, 1 insertion(+), 6 deletions(-)
lib/bbdev/meson.build +0 -6
index d8b95a400e..2e48d5f3da 100644
@@ -1,12 +1,6 @@
   # SPDX-License-Identifier: BSD-3-Clause
   # Copyright(c) 2017 Intel Corporation
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
   sources = files('rte_bbdev.c',
           'bbdev_trace_points.c')
   headers = files('rte_bbdev.h',
lib/bbdev/rte_bbdev.c +0 -0
index d7901cd29d..2c626806f3 100644

lib/bbdev/rte_bbdev.c line 19

Quoted 4 lines
lib/bbdev/rte_bbdev.c +1 -0
@@ -16,6 +16,7 @@
   #include <rte_lcore.h>
   #include <rte_spinlock.h>
   #include <rte_interrupts.h>
+#include <sys/queue.h>

It should be included with other general includes, not with RTE ones. I can fix it while applying.

Quoted 9 lines

With this fixed:

Reviewed-by Maxime Coquelin <[email protected]>

Thanks,
Maxime

Quoted 2 lines
lib/bbdev/rte_bbdev.c +0 -0
   #include "rte_bbdev_op.h"
   #include "rte_bbdev.h"

Applied to next-baseband.

Thanks,
Maxime