devfreq: Add support for devices which can idle

PATCH MyungJoo Ham 2 participants 2 messages Oct 4, 2012 – Oct 5, 2012

Share & tools

MyungJoo Ham

author

2012-10-04 12:36 UTC #0 lore raw

Quoted 11 lines

This patchset updates devfreq core to add support for devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume when device is back online.
patch 1 introduce core design changes - per device work, decouple delayed work from core and event based interaction. patch 2 add devfreq suspend and resume apis.
patch 3 add new sysfs attribute for governor predicted next target frequency and callback for current device frequency.

Quoted 3 lines

The existing devfreq apis are kept intact. Two new apis devfreq_suspend_device() and devfreq_resume_device() are added to support suspend/resume of device devfreq.

Could you please tell me which version you have rebased?

It seems that the patchset has issues on applying over 3.6. (tried at a0d271cbfed1dd50278c6b06bead3d00ba0a88f9)

Quoted 22 lines

Changes since v1:
- revised locking mechanism
- added kerneldoc comments for load monitoring helper functions
- fixed minor review comments
Changes since v2:
- added new helper function for polling interval update
- handled work suspend/resume contention between devfreq driver and sysfs
Changes since v3:
- added additonal checks in suspend/resume to avoid invalid usage of apis
- added check in devfreq_monitor_start, not to start monitoring when polling_ms is set to zero.
--
Rajagopal Venkat (3):
devfreq: Core updates to support devices which can idle
devfreq: Add suspend and resume apis
devfreq: Add current freq callback in device profile

Quoted 20 lines

 Documentation/ABI/testing/sysfs-class-devfreq |  15 +-
 drivers/devfreq/devfreq.c                     | 481 ++++++++++++--------------
 drivers/devfreq/governor.h                    |  13 +
 drivers/devfreq/governor_performance.c        |  16 +-
 drivers/devfreq/governor_powersave.c          |  16 +-
 drivers/devfreq/governor_simpleondemand.c     |  33 ++
 drivers/devfreq/governor_userspace.c          |  23 +-
 include/linux/devfreq.h                       |  49 +--
 8 files changed, 353 insertions(+), 293 deletions(-)

Signature · 1 line

1.7.11.3

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay��,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m��G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��띠�◀?뻀�

Rajagopal Venkat

2012-10-05 07:33 UTC #1 lore raw

Quoted 11 lines · MyungJoo Ham

Quoted 11 lines
This patchset updates devfreq core to add support for devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume when device is back online.
patch 1 introduce core design changes - per device work, decouple delayed work from core and event based interaction. patch 2 add devfreq suspend and resume apis.
patch 3 add new sysfs attribute for governor predicted next target frequency and callback for current device frequency.

Quoted 8 lines

Quoted 3 lines
The existing devfreq apis are kept intact. Two new apis devfreq_suspend_device() and devfreq_resume_device() are added to support suspend/resume of device devfreq.
Could you please tell me which version you have rebased?
It seems that the patchset has issues on applying over 3.6. (tried at a0d271cbfed1dd50278c6b06bead3d00ba0a88f9)

These patches are rebased against Linus tree.

The 203b42f7317494ae5e5efc7be6fb7f29c927f102 commit, which renames INIT_DELAYED_WORK_DEFERRABLE to INIT_DEFERRABLE_WORK could be the reason for patchset not applying over 3.6.

Quoted 44 lines

Quoted 44 lines
Changes since v1:
- revised locking mechanism
- added kerneldoc comments for load monitoring helper functions
- fixed minor review comments
Changes since v2:
- added new helper function for polling interval update
- handled work suspend/resume contention between devfreq driver and sysfs
Changes since v3:
- added additonal checks in suspend/resume to avoid invalid usage of apis
- added check in devfreq_monitor_start, not to start monitoring when polling_ms is set to zero.
--
Rajagopal Venkat (3):
devfreq: Core updates to support devices which can idle
devfreq: Add suspend and resume apis
devfreq: Add current freq callback in device profile
 Documentation/ABI/testing/sysfs-class-devfreq |  15 +-
 drivers/devfreq/devfreq.c                     | 481 ++++++++++++--------------
 drivers/devfreq/governor.h                    |  13 +
 drivers/devfreq/governor_performance.c        |  16 +-
 drivers/devfreq/governor_powersave.c          |  16 +-
 drivers/devfreq/governor_simpleondemand.c     |  33 ++
 drivers/devfreq/governor_userspace.c          |  23 +-
 include/linux/devfreq.h                       |  49 +--
 8 files changed, 353 insertions(+), 293 deletions(-)
--
1.7.11.3

Signature · 2 lines

Regards,
Rajagopal