Skip to contentSkip to conversation

ebg-secure-boot-snakeoil: drop space in remove override

PATCH Arjunan, Srinu 2 participants 2 messages Mar 10, 2023 – Apr 19, 2023 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Can you please merge this change?

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Srinuvasan A
Sent: 06 March 2023 16:54
To: [email protected]
Cc: Kiszka, Jan (T CED) <[email protected]>; Arjunan, Srinu (DI SW CAS ES LI PBU RSOL) <[email protected]>
Subject: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

From: Srinuvasan A <[email protected]>

remove does not need leading spaces in front of the package, hence drop this one.

---
 doc/README.secureboot.md             | 2 +-
 kas/opt/ebg-secure-boot-snakeoil.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
doc/README.secureboot.md +1 -1
@@ -154,7 +154,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
 local_conf_header:
   secure-boot: |
kas/opt/ebg-secure-boot-snakeoil.yml +1 -1
index 3d0e3c9..f787c82 100644
@@ -22,7 +22,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
   secure-boot: |
     IMAGER_BUILD_DEPS += "ebg-secure-boot-signer"

--
2.34.1

#2 lore raw
Quoted 2 lines · Srinu (DI SW CAS ES LI PBU RSOL)

Can you please merge this change?

Looks like a reported this as merged but somehow lost that state. It was still applying and is now truly in next.

Thanks,
Jan

Quoted 45 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Srinuvasan A
Sent: 06 March 2023 16:54
To: [email protected]
Cc: Kiszka, Jan (T CED) <[email protected]>; Arjunan, Srinu (DI SW CAS ES LI PBU RSOL) <[email protected]>
Subject: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

From: Srinuvasan A <[email protected]>

remove does not need leading spaces in front of the package, hence drop this one.

---
 doc/README.secureboot.md             | 2 +-
 kas/opt/ebg-secure-boot-snakeoil.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
doc/README.secureboot.md +1 -1
@@ -154,7 +154,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
 local_conf_header:
   secure-boot: |
kas/opt/ebg-secure-boot-snakeoil.yml +1 -2
index 3d0e3c9..f787c82 100644
@@ -22,7 +22,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
   secure-boot: |
     IMAGER_BUILD_DEPS += "ebg-secure-boot-signer"
--

2.34.1

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux