Skip to contentSkip to conversation

staging: ced401: fix double unlock bug

PATCH New Daeseok Youn 1 participant 1 message Feb 25, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: ced401: fix double unlock bug

After spin_lock() is called, all of if-else conditions in this brace should reach the end of else and spin_unlock() must be called. So It doesn't need to call spin_unlock() without a return statement for handling an error.

Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock

---
 drivers/staging/ced1401/usb1401.c |    1 -
 1 file changed, 1 deletion(-)
drivers/staging/ced1401/usb1401.c +0 -1
index f441e33..c281fda 100644
@@ -1054,7 +1054,6 @@ static int Handle1401Esc(DEVICE_EXTENSION *pdx, char *pCh,
 				/*  This can never happen, really */
 				dev_err(&pdx->interface->dev,
 					"ERROR: DMA setup while transfer still waiting\n");
-				spin_unlock(&pdx->stagedLock);
 			} else {
 				if ((wTransType == TM_EXTTOHOST)
 				    || (wTransType == TM_EXTTO1401)) {
Signature · 3 lines
1.7.9.5

---