bpf, docs: Update pahole to 1.28 for selftests
Subsystems (2)
PATCH 1/1 bpf, docs: Update pahole to 1.28 for selftests
From: Hemanth Malla <[email protected]>
pahole 1.16 doesn't seem to be to sufficient anymore for running bpf selftests.
--- Documentation/bpf/bpf_devel_QA.rst | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Documentation/bpf/bpf_devel_QA.rst +1 -4
@@ -482,7 +482,7 @@ under test should match the config file fragment in tools/testing/selftests/bpf as closely as possible. Finally to ensure support for latest BPF Type Format features - -discussed in Documentation/bpf/btf.rst - pahole version 1.16 +discussed in Documentation/bpf/btf.rst - pahole version 1.28 is required for kernels built with CONFIG_DEBUG_INFO_BTF=y. pahole is delivered in the dwarves package or can be built from source at
@@ -502,9 +502,6 @@ codes from https://fedorapeople.org/~acme/dwarves -Some distros have pahole version 1.16 packaged already, e.g. -Fedora, Gentoo. - Q: Which BPF kernel selftests version should I run my kernel against? --------------------------------------------------------------------- A: If you run a kernel ``xyz``, then always run the BPF kernel selftests
Signature · 1 line
2.43.0
Quoted 15 lines · Hemanth Malla
From: Hemanth Malla <[email protected]>
pahole 1.16 doesn't seem to be to sufficient anymore for running bpf selftests.
Signed-off-by Hemanth Malla <[email protected]>--- Documentation/bpf/bpf_devel_QA.rst | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Documentation/bpf/bpf_devel_QA.rst +0
-0
Documentation/bpf/bpf_devel_QA.rst under test should match the config file fragment in · line 485
Quoted 5 lines
Documentation/bpf/bpf_devel_QA.rst +1
-1@@ -482,7 +482,7 @@ under test should match the config file fragment in tools/testing/selftests/bpf as closely as possible. Finally to ensure support for latest BPF Type Format features - -discussed in Documentation/bpf/btf.rst - pahole version 1.16 +discussed in Documentation/bpf/btf.rst - pahole version 1.28
Hi Hemanth, thanks for the patch.
1.28 is needed for --distilled_base [1], which is only a requirement for tests using modules. Many other tests are likely to work with older versions, but the minimum for the kernel build is 1.22 now [2].
Not sure if it's worth it to add this nuance to the QA doc, although in general we should recommend people running the selftests to use the latest pahole release. Maybe add a comment?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/bpf/btf.rst?h=v6.18#n986
[2] https://lore.kernel.org/bpf/[email protected]/
Quoted 13 lines
Documentation/bpf/bpf_devel_QA.rst +0
-3is required for kernels built with CONFIG_DEBUG_INFO_BTF=y. pahole is delivered in the dwarves package or can be built from source at@@ -502,9 +502,6 @@ codes from https://fedorapeople.org/~acme/dwarves -Some distros have pahole version 1.16 packaged already, e.g. -Fedora, Gentoo. - Q: Which BPF kernel selftests version should I run my kernel against? --------------------------------------------------------------------- A: If you run a kernel ``xyz``, then always run the BPF kernel selftests
Quoted 16 lines · Ihor Solodrai
Documentation/bpf/bpf_devel_QA.rst under test should match the config file fragment in · line 485
Quoted 10 lines · Hemanth Malla
Documentation/bpf/bpf_devel_QA.rst +1
-1@@ -482,7 +482,7 @@ under test should match the config file fragment in tools/testing/selftests/bpf as closely as possible. Finally to ensure support for latest BPF Type Format features - -discussed in Documentation/bpf/btf.rst - pahole version 1.16 +discussed in Documentation/bpf/btf.rst - pahole version 1.28Hi Hemanth, thanks for the patch.
Acked-by Ihor Solodrai <[email protected]>
Quoted 7 lines
1.28 is needed for --distilled_base [1], which is only a requirement for tests using modules. Many other tests are likely to work with older versions, but the minimum for the kernel build is 1.22 now [2].
Not sure if it's worth it to add this nuance to the QA doc, although in general we should recommend people running the selftests to use the latest pahole release. Maybe add a comment?
I guess minimum pahole version can be added toDocumentation/process/changes.rst.
Thanks.
Signature · 1 line
An old man doll... just what I always wanted! - Clara
Hi Ihor,
Quoted 7 lines
1.28 is needed for --distilled_base [1], which is only a requirement for tests using modules. Many other tests are likely to work with older versions, but the minimum for the kernel build is 1.22 now [2].
Not sure if it's worth it to add this nuance to the QA doc, although in general we should recommend people running the selftests to use the latest pahole release. Maybe add a comment?
Thanks for the references. Makes sense to include these in the docs. I'll send out a new patch.
Thanks,
Hemanth Malla
Quoted 22 lines · Bagas Sanjaya
Quoted 20 lines · Ihor Solodrai
Documentation/bpf/bpf_devel_QA.rst under test should match the config file fragment in · line 485
Quoted 10 lines · Hemanth Malla
Documentation/bpf/bpf_devel_QA.rst +1
-1@@ -482,7 +482,7 @@ under test should match the config file fragment in tools/testing/selftests/bpf as closely as possible. Finally to ensure support for latest BPF Type Format features - -discussed in Documentation/bpf/btf.rst - pahole version 1.16 +discussed in Documentation/bpf/btf.rst - pahole version 1.28Hi Hemanth, thanks for the patch.
Acked-by Ihor Solodrai <[email protected]>1.28 is needed for --distilled_base [1], which is only a requirement for tests using modules. Many other tests are likely to work with older versions, but the minimum for the kernel build is 1.22 now [2].
Quoted 6 lines
Quoted 3 lines
Not sure if it's worth it to add this nuance to the QA doc, although in general we should recommend people running the selftests to use the latest pahole release. Maybe add a comment?
I guess minimum pahole version can be added to
Documentation/process/changes.rst.
pahole 1.22 is already specified in Documentation/process/changes.rst
Quoted 5 lines
Thanks.
--
An old man doll... just what I always wanted! - Clara
Quoted 11 lines · Andrii Nakryiko
Quoted 8 lines · Bagas Sanjaya
Quoted 3 lines · Ihor Solodrai
Not sure if it's worth it to add this nuance to the QA doc, although in general we should recommend people running the selftests to use the latest pahole release. Maybe add a comment?
I guess minimum pahole version can be added to
Documentation/process/changes.rst.pahole 1.22 is already specified in
Documentation/process/changes.rst
Oops, I didn't see that pointer.
Thanks.
Signature · 1 line
An old man doll... just what I always wanted! - Clara