Skip to contentSkip to conversation

kernel-module-split add systemd modulesloaddir and modprobedir config

PATCH Jose Quaresma 2 participants 3 messages Jul 4, 2023 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

gentle ping

Jose Quaresma via lists.openembedded.org <quaresma.jose= [email protected]> escreveu no dia sexta, 30/06/2023 à(s) 16:50:

Quoted 38 lines
---
 meta/classes-recipe/kernel-module-split.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes-recipe/kernel-module-split.bbclass +1 -2
index 0e4f9a6ec3..c1208d55e0 100644
@@ -30,8 +30,8 @@ fi
 
 PACKAGE_WRITE_DEPS += "kmod-native depmodwrapper-cross"
 
-modulesloaddir ??= "${sysconfdir}/modules-load.d"
-modprobedir ??= "${sysconfdir}/modprobe.d"
+modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',

'${nonarch_libdir}', '${sysconfdir}', d)}/modules-load.d" +modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '${nonarch_base_libdir}', '${sysconfdir}', d)}/modprobe.d"

KERNEL_SPLIT_MODULES ?= "1" PACKAGESPLITFUNCS =+ "split_kernel_module_packages"
--
2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#183704):
https://lists.openembedded.org/g/openembedded-core/message/183704
Mute This Topic: https://lists.openembedded.org/mt/99875687/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma
#2 lore raw

The colon can be fixed but a rationale for this change would be useful.

Ross

Quoted 46 lines · Jose Quaresma via lists.openembedded.org

gentle ping

Jose Quaresma via lists.openembedded.org <[email protected]> escreveu no dia sexta, 30/06/2023 à(s) 16:50:

---
 meta/classes-recipe/kernel-module-split.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes-recipe/kernel-module-split.bbclass +2 -2
index 0e4f9a6ec3..c1208d55e0 100644
@@ -30,8 +30,8 @@ fi
 
 PACKAGE_WRITE_DEPS += "kmod-native depmodwrapper-cross"
 
-modulesloaddir ??= "${sysconfdir}/modules-load.d"
-modprobedir ??= "${sysconfdir}/modprobe.d"
+modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '${nonarch_libdir}', '${sysconfdir}', d)}/modules-load.d"
+modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '${nonarch_base_libdir}', '${sysconfdir}', d)}/modprobe.d"
 
 KERNEL_SPLIT_MODULES ?= "1"
 PACKAGESPLITFUNCS =+ "split_kernel_module_packages"
Signature · 19 lines
2.34.1






-- 
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#183818): https://lists.openembedded.org/g/openembedded-core/message/183818
Mute This Topic: https://lists.openembedded.org/mt/99875687/6875888
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
#3 lore raw

Ross Burton <[email protected]> escreveu no dia terça, 4/07/2023 à(s) 11:03:

Quoted 2 lines

The colon can be fixed but a rationale for this change would be useful.

Sure, I will send a v2 explaining:

Because busybox doesn't support other path than /etc [1] we can't change the default path unconditionally so change it only for systemd.

Jose

Quoted 59 lines

Ross

Quoted 1 line

On 4 Jul 2023, at 10:03, Jose Quaresma via lists.openembedded.org

Quoted 4 lines · <[email protected]> wrote:

gentle ping

Jose Quaresma via lists.openembedded.org <quaresma.jose=

[email protected]> escreveu no dia sexta, 30/06/2023 à(s) 16:50:

Review

Quoted 6 lines
---
 meta/classes-recipe/kernel-module-split.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/meta/classes-recipe/kernel-module-split.bbclass

meta/classes-recipe/kernel-module-split.bbclass fi · line 33

Quoted 10 lines

index 0e4f9a6ec3..c1208d55e0 100644

meta/classes-recipe/kernel-module-split.bbclass +1 -2
@@ -30,8 +30,8 @@ fi
 
 PACKAGE_WRITE_DEPS += "kmod-native depmodwrapper-cross"
 
-modulesloaddir ??= "${sysconfdir}/modules-load.d"
-modprobedir ??= "${sysconfdir}/modprobe.d"
+modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',

'${nonarch_libdir}', '${sysconfdir}', d)}/modules-load.d"

meta/classes-recipe/kernel-module-split.bbclass fi · line 34

Quoted 1 line
meta/classes-recipe/kernel-module-split.bbclass +1 -0
+modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',

'${nonarch_base_libdir}', '${sysconfdir}', d)}/modprobe.d"

Quoted 11 lines
meta/classes-recipe/kernel-module-split.bbclass +0 -1
 KERNEL_SPLIT_MODULES ?= "1"
 PACKAGESPLITFUNCS =+ "split_kernel_module_packages"
--

2.34.1

Quoted 8 lines

--
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#183818):

https://lists.openembedded.org/g/openembedded-core/message/183818

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/99875687/6875888
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma