Skip to contentSkip to conversation

sstatesig: be more precise and show the full path in exceptions

PATCH Jose Quaresma 1 participant 1 message Sep 27, 2023 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Gentle ping.

The other patch of the series was rejected but imho this one is useful as it improves the error reporting.

Jose

Jose Quaresma via lists.openembedded.org <quaresma.jose= [email protected]> escreveu no dia quinta, 13/07/2023 à(s) 12:03:

Quoted 60 lines

Also remove the warning than doesn't make sense as the code will generate an exception and bitbake will abort.

Before:
| WARNING: core-image-minimal-initramfs-1.0-r0 do_image_complete: KeyError in .
| Exception: Exception: KeyError: 'getpwuid(): uid not found: xxxxx' | Path . is owned by uid xxxxx, gid yyy, which doesn't match any user/group on target. This may be due to host contamination.

After:
| Exception: Exception: KeyError: 'getpwuid(): uid not found: xxxxx'
| Path /build/tmp/work/intel_corei7_64-lmp-linux/core-image-minimal-initramfs/1.0-r0/sstate-build-image_complete is owned by uid xxxxx, gid yyy, which doesn't match any user/group on
target. This may be due to host contamination.

---
 meta/lib/oe/sstatesig.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/lib/oe/sstatesig.py +0 -1
index 30f27b0f4f..4a886215b2 100644
@@ -595,9 +595,9 @@ def OEOuthashBasic(path, sigfile, task, d):
                         update_hash(" %10s" %
 pwd.getpwuid(s.st_uid).pw_name)
                         update_hash(" %10s" %
 grp.getgrgid(s.st_gid).gr_name)
                     except KeyError as e:
-                        bb.warn("KeyError in %s" % path)
                         msg = ("KeyError: %s\nPath %s is owned by uid %d,

gid %d, which doesn't match "
- "any user/group on target. This may be due to
host contamination." % (e, path, s.st_uid, s.st_gid))
+ "any user/group on target. This may be due to
host contamination." %
+ (e, os.path.abspath(path), s.st_uid,
s.st_gid))
raise
Exception(msg).with_traceback(e.__traceback__)

if include_timestamps:
--
2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#184240):
https://lists.openembedded.org/g/openembedded-core/message/184240
Mute This Topic: https://lists.openembedded.org/mt/100117925/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma