request_firmware() gives build failures
Just tried building -rc2 (then current git) and got a few errors like:
drivers/built-in.o: In function `generic_set_freq':
tuner-xc2028.c:(.text+0x90f42): undefined reference to request_firmware' tuner-xc2028.c:(.text+0x91418): undefined reference to release_firmware'
A bit of digging turned up the problem: I had fw_loader configured as a module, but some drivers which need it were configured built-in. Don't ask why I had those drivers configured in at all...time to prune that .config I've been carrying around...
In any case, setting CONFIG_FW_LOADER=y makes the problem go away. I'm not good enough at kconfig to make that happen magically; putting in "select FW_LOADER" doesn't seem to be enough. In any case, given that callers to request_firmware() can be built in, does it make sense to have an option to make the firmware loader modular?
jon
Quoted 3 lines · Jonathan Corbet
In any case, setting
CONFIG_FW_LOADER=ymakes the problem go away. I'm not good enough at kconfig to make that happen magically; putting in "selectFW_LOADER" doesn't seem to be enough.
Maybe I overlooked something, but I fix that way the same issue today. What exactly doesn't work with select FW_LOADER?
$ grep FW ../a/moxa/.config CONFIG_FW_LOADER=m $ grep INTELL ../a/moxa/.config CONFIG_MOXA_INTELLIO=y $ vim drivers/char/Kconfig <add select FW_LOADER to MOXA_INTELLIO> $ make O=../a/moxa/ SUBARCH=i386 drivers/char/moxa.o GEN /home/l/latest/a/moxa/Makefile scripts/kconfig/conf -s arch/x86/Kconfig # # configuration written to .config # fatal: cannot describe '18f96f01977fa1905fd0f8f8522698cc97287022' Using /home/l/latest/xxx as source for kernel GEN /home/l/latest/a/moxa/Makefile CHK include/linux/version.h CHK include/linux/utsrelease.h CALL /home/l/latest/xxx/scripts/checksyscalls.sh CC drivers/char/moxa.o $ grep FW ../a/moxa/.config CONFIG_FW_LOADER=y