power: max17042_battery: Add DT bindings
Karol Lewandowski<[email protected]>, 2012-03-10 02:32 (GMT+09:00)
Quoted 5 lines
Dear MungJoo,
I wasn't aware of Dirk's patchset and thus, I didn't ever try to make my patches compatible with it.
Quoted 7 lines
I've found hopefully correct patchset[1] via google - it's mailing list posting without any feedback... I've checked linux-next and it clearly hasn't been merged.
I'm happy to rework my patch but I would like to ask you about specific tree I should base on. Is this patchset in some subsystem-specific (power?) tree? Other?
Dear Karol,
I preferred Dirk's patchset included because it is for the correctness of the device driver.
However, as Dirk's patchset has not been updated or merged for long, I guess you may go ahead trying to merge this DT patchset first.
It appears that this patchset does not force much trouble for Dirk's side as the two are virtually disjoint and it seems rebasing Dirk's patchset upon this patchset trivial though I didn't try that yet.
Anyway, please consider "Acked-by" from me for the patches.
Cheers!
MyungJoo.
Quoted 41 lines
[1] https://lkml.org/lkml/2012/1/24/237
Regards,
Signature · 1 line
Karol Lewandowski | Samsung Poland R&D Center | Linux/PlatformQuoted 27 lines · 함명주
Dear Karol Lewandowski,
I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
Anyway, the patches themselves look fine.
However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
Thank you.
Cheers!
MyungJoo.------- Original Message -------
Sender : Karol Lewandowski Junior Software Engineer/SPRC-Linux (MSD)/삼성전자 Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power:max17042_battery: Add DT bindingsDear MyungJoo Ham,
Could you take a look at patchset I've sent? It's needed to make use of max17042 driver on device tree-enabled platforms.
Regards,
--
MyungJoo Ham (함명주), PHD
System S/W Lab, S/W Platform Team, Software Center Samsung Electronics
Cell: +82-10-6714-2858
�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay� ���,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�
Hi All,
Quoted 14 lines · 함명주
Karol Lewandowski<[email protected]>, 2012-03-10 02:32 (GMT+09:00)
Quoted 5 lines
Dear MungJoo,
I wasn't aware of Dirk's patchset and thus, I didn't ever try to make my patches compatible with it.
Quoted 7 lines
I've found hopefully correct patchset[1] via google - it's mailing list posting without any feedback... I've checked linux-next and it clearly hasn't been merged.
I'm happy to rework my patch but I would like to ask you about specific tree I should base on. Is this patchset in some subsystem-specific (power?) tree? Other?
Quoted 6 lines
Dear Karol,
I preferred Dirk's patchset included because it is for the correctness of the device driver.
However, as Dirk's patchset has not been updated or merged for long, I guess you may go ahead trying to merge this DT patchset first.
My patch set was updated on 24/1/12 and has all my changes to date. I am not sure why it
has not been merged Anton, David?
Quoted 2 lines
It appears that this patchset does not force much trouble for Dirk's side as the two are virtually disjoint and it seems rebasing Dirk's patchset upon this patchset trivial though I didn't try that yet.
Agreed, I would like to see my patches make the 3.4 though since they have been out for a while
Quoted 60 lines
Anyway, please consider "Acked-by" from me for the patches.
Cheers!
MyungJoo.Quoted 41 lines
[1] https://lkml.org/lkml/2012/1/24/237
Regards,
Signature · 1 line
Karol Lewandowski | Samsung Poland R&D Center | Linux/PlatformQuoted 27 lines · 함명주
Dear Karol Lewandowski,
I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
Anyway, the patches themselves look fine.
However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
Thank you.
Cheers!
MyungJoo.------- Original Message -------
Sender : Karol Lewandowski Junior Software Engineer/SPRC-Linux (MSD)/삼성전자 Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power:max17042_battery: Add DT bindingsDear MyungJoo Ham,
Could you take a look at patchset I've sent? It's needed to make use of max17042 driver on device tree-enabled platforms.
Regards,
--
MyungJoo Ham (함명주), PHD
System S/W Lab, S/W Platform Team, Software Center Samsung Electronics
Cell: +82-10-6714-2858