Skip to contentSkip to conversation

Thermal: cpufreq cooling fix

PATCH amit daniel kachhap 3 participants 3 messages Mar 15, 2013 – Mar 20, 2013 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi Rui,

For both the patches,
Acked by: Amit Daniel kachhap <[email protected]>

Thanks,
Amit Daniel

Quoted 42 lines · AMIT DANIEL KACHHAP

------- Original Message -------
Sender : Zhang Rui<[email protected]>
Date : Mar 12, 2013 00:33 (GMT+09:00)
Title : [PATCH V3 0/2] Thermal: cpufreq cooling fix

cpufreq cooling uses different frequencies as different cooling states.

But the per_cpu cpufreq_frequency_table may contain duplicate, invalid entries, and it may be in either ascending or descending order. And currently, code for parsing the per_cpu cpufreq_frequency_table is used in several places and inconsistent.

To fix this,
New code is introduce in Patch 1/2, which contains the logic of parsing per_cpu cpufreq_frequency_table, and this piece of code can be used to:
1. get the maximum cooling states
2. translate cpu frequency to cooling state
3. translate cooling state to cpu frequency

Patch 2/2 converts exynos_thermal driver to use the new code introduced in Patch 1/2.

History:
V3: fix wrong return value of get_cpu_frequency().
fix wrong return value of get_property() when property equals GET_MAXL.

V2: remove cpu cooling table to avoid extra memory allocation.

V1: introduce code to convert per_cpu cpufreq_frequency_table
to clean cpu cooling table (no invalid entry, no duplicate entry, in descending order).

I just run build test here. It would be great that some of you can test it on exynos.
any comments?

thanks,
rui
<p>&nbsp;</p><p>&nbsp;</p>

#2 lore raw

Hi, Amit,

Quoted 5 lines · amit daniel kachhap

Hi Rui,

For both the patches,
Acked by: Amit Daniel kachhap <[email protected]>

thanks. Do you have a chance to test these patches?

-rui

Quoted 51 lines

Thanks,
Amit Daniel

Quoted 35 lines · AMIT DANIEL KACHHAP

------- Original Message -------
Sender : Zhang Rui<[email protected]>
Date : Mar 12, 2013 00:33 (GMT+09:00)
Title : [PATCH V3 0/2] Thermal: cpufreq cooling fix

cpufreq cooling uses different frequencies as different cooling states.

But the per_cpu cpufreq_frequency_table may contain duplicate, invalid entries, and it may be in either ascending or descending order. And currently, code for parsing the per_cpu cpufreq_frequency_table is used in several places and inconsistent.

To fix this,
New code is introduce in Patch 1/2, which contains the logic of parsing per_cpu cpufreq_frequency_table, and this piece of code can be used to:
1. get the maximum cooling states
2. translate cpu frequency to cooling state
3. translate cooling state to cpu frequency

Patch 2/2 converts exynos_thermal driver to use the new code introduced in Patch 1/2.

History:
V3: fix wrong return value of get_cpu_frequency().
fix wrong return value of get_property() when property equals GET_MAXL.

V2: remove cpu cooling table to avoid extra memory allocation.

V1: introduce code to convert per_cpu cpufreq_frequency_table
to clean cpu cooling table (no invalid entry, no duplicate entry, in descending order).

Quoted 7 lines

I just run build test here. It would be great that some of you can test it on exynos.
any comments?

thanks,
rui
<p>&nbsp;</p><p>&nbsp;</p>

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 9 lines · Zhang Rui

Hi, Amit,

Quoted 5 lines · amit daniel kachhap

Hi Rui,

For both the patches,
Acked by: Amit Daniel kachhap <[email protected]>

thanks. Do you have a chance to test these patches?

yes I tested them and they are fine.
Feel free to add,
Tested by: Amit Daniel kachhap <[email protected]>

Thanks,
Amit Daniel

Quoted 56 lines

-rui

Quoted 51 lines

Thanks,
Amit Daniel

Quoted 35 lines · AMIT DANIEL KACHHAP

------- Original Message -------
Sender : Zhang Rui<[email protected]>
Date : Mar 12, 2013 00:33 (GMT+09:00)
Title : [PATCH V3 0/2] Thermal: cpufreq cooling fix

cpufreq cooling uses different frequencies as different cooling states.

But the per_cpu cpufreq_frequency_table may contain duplicate, invalid entries, and it may be in either ascending or descending order. And currently, code for parsing the per_cpu cpufreq_frequency_table is used in several places and inconsistent.

To fix this,
New code is introduce in Patch 1/2, which contains the logic of parsing per_cpu cpufreq_frequency_table, and this piece of code can be used to:
1. get the maximum cooling states
2. translate cpu frequency to cooling state
3. translate cooling state to cpu frequency

Patch 2/2 converts exynos_thermal driver to use the new code introduced in Patch 1/2.

History:
V3: fix wrong return value of get_cpu_frequency().
fix wrong return value of get_property() when property equals GET_MAXL.

V2: remove cpu cooling table to avoid extra memory allocation.

V1: introduce code to convert per_cpu cpufreq_frequency_table
to clean cpu cooling table (no invalid entry, no duplicate entry, in descending order).

Quoted 7 lines

I just run build test here. It would be great that some of you can test it on exynos.
any comments?

thanks,
rui
<p>&nbsp;</p><p>&nbsp;</p>

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html