Skip to contentSkip to conversation

oeqa,ssh: Handle SSHCall timeout error code

PATCH Luca Fancellu 2 participants 3 messages Nov 13, 2023 – Nov 14, 2023 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi all,

Quoted 14 lines · luca fancellu via lists.openembedded.org

The current code in ssh.py is terminating the ssh process that does not finish its computation in a given timeout (when timeout is passed), the SSHCall function is returning the process error code.

The Openssl ssh before version 8.6_p1 is returning 0 when it is terminated, from commit 8a9520836e71830f4fccca066dba73fea3d16bda onwards (version >= 8.6_p1) ssh is returning 255 instead.

So for version of ssh older than 8.6_p1 when the SSHCall time out, the return code will be 0, meaning success, which is wrong.

Quoted 8 lines

Fix this issue checking if the process has timeout (hence it's been terminated) and checking if the returned code is 0, in that case set it to 255 to advertise that an error occurred.

Add a test case excercising the timeout in the SSHTest, test_ssh test function.

I see this one has been merged in master:
https://git.yoctoproject.org/poky/commit/?id=0f25c8aa775001166a03b8b215b7b9ab80ef4f9e

Is it possible to backport this fix also to mickledore? Or should I send a patch with [mickledore] tag?

Cheers,
Luca

#2 lore raw
Quoted 4 lines · luca fancellu via lists.openembedded.org

I see this one has been merged in master:
https://git.yoctoproject.org/poky/commit/?id=0f25c8aa775001166a03b8b215b7b9ab80ef4f9e

Is it possible to backport this fix also to mickledore? Or should I send a patch with [mickledore] tag?

Doing the backport and posting the patch is the usual process, to reduce the amount of work and testing needed to be done by the release maintainer.

It’s also usual to backport to any intermediate releases so that changes don’t revert if someone upgrades.

(I see you’ve both sent the backports and included nanbield, so this mail is just confirming the process for the list really)

Ross

#3 lore raw
Quoted 8 lines · Ross Burton
Quoted 3 lines · luca fancellu via lists.openembedded.org

I see this one has been merged in master:
https://git.yoctoproject.org/poky/commit/?id=0f25c8aa775001166a03b8b215b7b9ab80ef4f9e

Quoted 7 lines
Quoted 1 line

Is it possible to backport this fix also to mickledore? Or should I send a patch with [mickledore] tag?

Doing the backport and posting the patch is the usual process, to reduce the amount of work and testing needed to be done by the release maintainer.

It’s also usual to backport to any intermediate releases so that changes don’t revert if someone upgrades.

(I see you’ve both sent the backports and included nanbield, so this mail is just confirming the process for the list really)

Thank you for confirming that Ross.

Cheers,
Luca