gettext: fix a parallel build issue
Hi, Steve
Could you help to cherry-pick this patch to scarthgap? Thanks
Regards
Changqing
Quoted 91 lines · Changqing Li
From: Changqing Li<[email protected]>
Occasionally, gettext will build failed with error:
In file included from../../../gettext-0.22.5/gettext-runtime/intl/gettextP.h:71,from ../../../gettext-0.22.5/gettext-runtime/intl/log.c:24:./libgnuintl.h:98:1: error: unterminated comment
98 | /* The user can define_INTL_RE
| ^
./libgnuintl.h:17: error: unterminated #ifndef17 | #ifndef _LIBINTL_HIn file included from
../../../gettext-0.22.5/gettext-runtime/intl/gettextP.h:71,from ../../../gettext-0.22.5/gettext-runtime/intl/langprefs.c:25:./libgnuintl.h:98:1: error: unterminated comment
98 | /* The user can define_INTL_RE
| ^
./libgnuintl.h:17: error: unterminated #ifndef17 | #ifndef _LIBINTL_HIt is a parallel build issue caused by missing dependencies, backport patch to fix it.
Signed-off-by Changqing Li<[email protected]>--- ...1-intl-Fix-build-failure-with-make-j.patch | 35 +++++++++++++++++++ meta/recipes-core/gettext/gettext_0.22.5.bb | 1 + 2 files changed, 36 insertions(+)create mode 100644
meta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patchmeta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patch new file +35
-0@@ -0,0 +1,35 @@ +From 97a6a63ad61949663283f5fad68c9d5fb9be1f15 Mon Sep 17 00:00:00 2001 +From: Bruno Haible<[email protected]> +Date: Tue, 12 Sep 2023 11:33:41 +0200 +Subject: [PATCH] intl: Fix build failure with "make -j". + +Reported by Christian Weisgerber<[email protected]> at +<https://lists.gnu.org/archive/html/bug-gettext/2023-09/msg00005.html>. + +* gettext-runtime/intl/Makefile.am (langprefs.lo, log.lo): Depend on gettextP.h +and its subordinate includes. + +Upstream-Status: Backport [https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commit;h=97a6a63ad61949663283f5fad68c9d5fb9be1f15] +Signed-off-by: Changqing Li<[email protected]> +--- + gettext-runtime/intl/Makefile.am | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gettext-runtime/intl/Makefile.am b/gettext-runtime/intl/Makefile.am +index da7abb758..9e56978bc 100644 +--- a/gettext-runtime/intl/Makefile.am ++++ b/gettext-runtime/intl/Makefile.am +@@ -387,8 +387,8 @@ dngettext.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo + ngettext.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + plural.lo: ../config.h $(srcdir)/plural-exp.h $(PLURAL_DEPS) + plural-exp.lo: ../config.h $(srcdir)/plural-exp.h +-langprefs.lo: ../config.h +-log.lo: ../config.h ++langprefs.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h ++log.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + printf.lo: ../config.h + setlocale.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + version.lo: ../config.h libgnuintl.h +-- +2.25.1 +meta/recipes-core/gettext/gettext_0.22.5.bb +1
-1@@ -28,6 +28,7 @@ SRC_URI += " \ file://serial-tests-config.patch \ file://0001-tests-autopoint-3-unset-MAKEFLAGS.patch \ file://0001-init-env.in-do-not-add-C-CXX-parameters.patch \ +file://0001-intl-Fix-build-failure-with-make-j.patch \ " inherit autotools texinfo pkgconfig ptest -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#199962):https://lists.openembedded.org/g/openembedded-core/message/199962 Mute This Topic:https://lists.openembedded.org/mt/106345410/3616873
Group Owner:[email protected] Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 4 lines · Changqing Li
Hi, Steve
Could you help to cherry-pick this patch to scarthgap? Thanks
Yes, will do.
Steve
Quoted 99 lines
Regards
Changqing
On 5/28/24 17:11, Changqing Li wrote:
From: Changqing Li <[email protected]>
Occasionally, gettext will build failed with error:
In file included from../../../gettext-0.22.5/gettext-runtime/intl/gettextP.h:71,from ../../../gettext-0.22.5/gettext-runtime/intl/log.c:24: ./libgnuintl.h:98:1: error: unterminated comment 98 | /* The user can define _INTL_RE | ^./libgnuintl.h:17: error: unterminated #ifndef
17 | #ifndef_LIBINTL_HIn file included from
../../../gettext-0.22.5/gettext-runtime/intl/gettextP.h:71,from ../../../gettext-0.22.5/gettext-runtime/intl/langprefs.c:25: ./libgnuintl.h:98:1: error: unterminated comment 98 | /* The user can define _INTL_RE | ^./libgnuintl.h:17: error: unterminated #ifndef
17 | #ifndef_LIBINTL_HIt is a parallel build issue caused by missing dependencies, backport patch to fix it.
Signed-off-by Changqing Li <[email protected]>--- ...1-intl-Fix-build-failure-with-make-j.patch | 35 +++++++++++++++++++ meta/recipes-core/gettext/gettext_0.22.5.bb | 1 + 2 files changed, 36 insertions(+) create mode 100644 meta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patchmeta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patch new file +35
-0@@ -0,0 +1,35 @@ +From 97a6a63ad61949663283f5fad68c9d5fb9be1f15 Mon Sep 17 00:00:00 2001 +From: Bruno Haible <[email protected]> +Date: Tue, 12 Sep 2023 11:33:41 +0200 +Subject: [PATCH] intl: Fix build failure with "make -j". + +Reported by Christian Weisgerber <[email protected]> at +<https://lists.gnu.org/archive/html/bug-gettext/2023-09/msg00005.html>. + +* gettext-runtime/intl/Makefile.am (langprefs.lo, log.lo): Depend on gettextP.h +and its subordinate includes. + +Upstream-Status: Backport [https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commit;h=97a6a63ad61949663283f5fad68c9d5fb9be1f15] +Signed-off-by: Changqing Li <[email protected]> +--- + gettext-runtime/intl/Makefile.am | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gettext-runtime/intl/Makefile.am b/gettext-runtime/intl/Makefile.am +index da7abb758..9e56978bc 100644 +--- a/gettext-runtime/intl/Makefile.am ++++ b/gettext-runtime/intl/Makefile.am +@@ -387,8 +387,8 @@ dngettext.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo + ngettext.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + plural.lo: ../config.h $(srcdir)/plural-exp.h $(PLURAL_DEPS) + plural-exp.lo: ../config.h $(srcdir)/plural-exp.h +-langprefs.lo: ../config.h +-log.lo: ../config.h ++langprefs.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h ++log.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + printf.lo: ../config.h + setlocale.lo: ../config.h $(srcdir)/gettextP.h libgnuintl.h $(srcdir)/gmo.h $(srcdir)/loadinfo.h + version.lo: ../config.h libgnuintl.h +-- +2.25.1 +meta/recipes-core/gettext/gettext_0.22.5.bb +1
-1@@ -28,6 +28,7 @@ SRC_URI += " \ file://serial-tests-config.patch \ file://0001-tests-autopoint-3-unset-MAKEFLAGS.patch \ file://0001-init-env.in-do-not-add-C-CXX-parameters.patch \ + file://0001-intl-Fix-build-failure-with-make-j.patch \ " inherit autotools texinfo pkgconfig ptest -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#199962): https://lists.openembedded.org/g/openembedded-core/message/199962
Mute This Topic: https://lists.openembedded.org/mt/106345410/3616873
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-