Skip to contentSkip to conversation

classes/kernel: No symlink in postinst without KERNEL_IMAGETYPE_SYMLINK

PATCH Jörg Sommer 2 participants 3 messages Jun 9, 2024 – Jun 17, 2024 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):

Quoted 16 lines
meta/classes-recipe/kernel.bbclass +3 -1
index d6eedf942c..89badd90f1 100644
@@ -115,7 +115,9 @@ python __anonymous () {
 
         d.setVar('PKG:%s-image-%s' % (kname,typelower), '%s-image-%s-${KERNEL_VERSION_PKG_NAME}' % (kname, typelower))
         d.setVar('ALLOW_EMPTY:%s-image-%s' % (kname, typelower), '1')
-        d.prependVar('pkg_postinst:%s-image-%s' % (kname,typelower), """set +e
+
+        if d.getVar('KERNEL_IMAGETYPE_SYMLINK') == '1':
+            d.prependVar('pkg_postinst:%s-image-%s' % (kname,typelower), """set +e
 if [ -n "$D" ]; then
     ln -sf %s-${KERNEL_VERSION} $D/${KERNEL_IMAGEDEST}/%s > /dev/null 2>&1
 else

meta/classes-recipe/kernel.bbclass else · line 132

Quoted 5 lines
meta/classes-recipe/kernel.bbclass +1 -1
@@ -127,7 +129,7 @@ else
 fi
 set -e
 """ % (type, type, type, type, type, type, type))
-        d.setVar('pkg_postrm:%s-image-%s' % (kname,typelower), """set +e
+            d.setVar('pkg_postrm:%s-image-%s' % (kname,typelower), """set +e

While backporting this patch to kirkstone I realised this uses setVar instead of prependVar (as above). Is this right?

#2 lore raw
In reply to a message not in the archive

Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):

Quoted 10 lines

From: Jörg Sommer <[email protected]>

The commit “Use a copy of image for kernel*.rpm if fs doesn't support symlinks” [1] added postinst and postrm scripts to the kernel package which create a symlink after package installation. This should not happen if KERNEL_IMAGETYPE_SYMLINK is not 1.

Background: The u-boot implementation of jffs2 does not support symlinks. Using a hardlink or removing ${KERNEL_VERSION} from the file name fails, because the current postinst script replaces the file with the symlink.

Gently ping.

#3 lore raw
Quoted 8 lines · Jörg Sommer via lists.openembedded.org

Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):

Quoted 7 lines

From: Jörg Sommer <[email protected]>

The commit “Use a copy of image for kernel*.rpm if fs doesn't support symlinks” [1] added postinst and postrm scripts to the kernel package which create a symlink after package installation. This should not happen if KERNEL_IMAGETYPE_SYMLINK is not 1.

Quoted 5 lines
Quoted 3 lines

Background: The u-boot implementation of jffs2 does not support symlinks. Using a hardlink or removing ${KERNEL_VERSION} from the file name fails, because the current postinst script replaces the file with the symlink.

Gently ping.

Testing is ongoing

Quoted 9 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200795): https://lists.openembedded.org/g/openembedded-core/message/200795
Mute This Topic: https://lists.openembedded.org/mt/106576203/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com