Skip to contentSkip to conversation

kernel/fork.c: make dup_mm() static

PATCH Superseded Daeseok Youn 2 participants 3 messages Nov 27, 2013

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/fork.c: make dup_mm() static

From 50e7d2058f0502e9c9138d5c0c75c8492ab8ed6a Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 27 Nov 2013 10:17:59 +0900
Subject: [PATCH] kernel/fork.c: make dup_mm() static

---
 include/linux/sched.h |    2 --
 kernel/fork.c         |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
include/linux/sched.h +0 -2
index 7e35d4b..b04d7b1 100644
@@ -2167,8 +2167,6 @@ extern struct mm_struct *get_task_mm(struct task_struct *task);
 extern struct mm_struct *mm_access(struct task_struct *task, unsigned int mode);
 /* Remove the current tasks stale references to the old mm_struct */
 extern void mm_release(struct task_struct *, struct mm_struct *);
-/* Allocate a new mm structure and copy contents from tsk->mm */
-extern struct mm_struct *dup_mm(struct task_struct *tsk);
 
 extern int copy_thread(unsigned long, unsigned long, unsigned long,
 			struct task_struct *);
kernel/fork.c +1 -1
index 022a0af..1603aea 100644
@@ -799,7 +799,7 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm)
  * Allocate a new mm structure and copy contents from the
  * mm structure of the passed in task structure.
  */
-struct mm_struct *dup_mm(struct task_struct *tsk)
+static struct mm_struct *dup_mm(struct task_struct *tsk)
 {
 	struct mm_struct *mm, *oldmm = current->mm;
 	int err;
Signature · 3 lines
1.7.9.5

---
maintainer
#1 lore raw
Quoted 4 lines · Daeseok Youn

From 50e7d2058f0502e9c9138d5c0c75c8492ab8ed6a Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 27 Nov 2013 10:17:59 +0900
Subject: [PATCH] kernel/fork.c: make dup_mm() static

Strictly speaking you need a Changelog explaining what, why and how. I suppose here a simple:

Make dup_mm() static as its not used elsewhere.

Will suffice.

Quoted 1 line

Andrew, do you want this one or shall I take it?

#2 lore raw
In reply to Daeseok Youn

Thanks for review.

I will modify subject as your comment.
And I will re-send a patch again.

Daeseok Youn

2013/11/27 Peter Zijlstra <[email protected]>:

Quoted 16 lines · Daeseok Youn
Quoted 4 lines

From 50e7d2058f0502e9c9138d5c0c75c8492ab8ed6a Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 27 Nov 2013 10:17:59 +0900
Subject: [PATCH] kernel/fork.c: make dup_mm() static

Strictly speaking you need a Changelog explaining what, why and how. I suppose here a simple:

Make dup_mm() static as its not used elsewhere.

Will suffice.

Quoted 1 line

Andrew, do you want this one or shall I take it?