Skip to contentSkip to conversation

coccinelle: misc: add array_size_dup script to detect missed overflow checks

PATCH Markus Elfring 1 participant 1 message Jun 15, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw

I suggest to avoid a typo in the previous patch subject.

…

Review

Quoted 3 lines
(quoted diff) +3 -0
+virtual context
+virtual report
+virtual org

+virtual context, report, org

Is such a SmPL code variant more succinct?

…

Review

Quoted 3 lines

+@as_next@

(quoted diff) +2 -0
+expression subE1 <= as.E1;
+expression as.E1;

…

I propose to reduce the repetition of this SmPL key word.

…

Review

Quoted 2 lines
(quoted diff) +2 -0
+  ... when != \(E1\|E2\|subE1\|subE2\)=E3
+      when != \(E1\|E2\|subE1\|subE2\)+=E3

…

Can it make sense to express a constraint for a metavariable of the type “assignment operator”?

Quoted 1 line

+ when != \(&E1\|&E2\|&subE1\|&subE2\)

How do you think about to use the following code exclusion specification?

+ when != & \(E1 \| E2 \| subE1 \| subE2\)

…

Review

Quoted 2 lines
(quoted diff) +2 -0
+msg = "WARNING: same struct_size (line %s)" % (p1[0].line)
+coccilib.org.print_todo(p2[0], msg)

I suggest once more to pass the desired message object directly as a function argument (without using an extra Python variable).

Regards,
Markus