Skip to contentSkip to conversation

v4l2-subdev: add a v4l2_i2c_new_dev_subdev() function

PATCH Agustin 2 participants 2 messages Apr 21, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Agustin

author
#0 lore raw

Hi,

Quoted 6 lines · Guennadi Liakhovetski

Video (sub)devices, connecting to SoCs over generic i2c busses cannot provide a pointer to struct v4l2_device in i2c-adapter driver_data, and provide their own i2c_board_info data, including a platform_data field. Add a v4l2_i2c_new_dev_subdev() API function that does exactly the same as v4l2_i2c_new_subdev() but uses different parameters, and make v4l2_i2c_new_subdev() a wrapper around it.

[snip]

I am wondering about this ongoing effort and its pursued goal: is it to hierarchize the v4l architecture, adding new abstraction levels? If so, what for?

To me, as an eventual driver developer, this makes it harder to integrate my own drivers, as I use I2C and V4L in my system but I don't want them to be tightly coupled.

Of course I can ignore this "subdev" stuff and just link against soc-camera which is what I need, and manage I2C without V4L knowing about it. Which is what I do.

So, which is the point I am missing?

Regards,
--Agustín.

--
Agustin Ferrin Pozuelo
Embedded Systems Consultant
http://embedded.ferrin.org
Tel. +34 610502587

#1 lore raw
Quoted 11 lines · Agustin

Hi,

Quoted 6 lines · Guennadi Liakhovetski

Video (sub)devices, connecting to SoCs over generic i2c busses cannot provide a pointer to struct v4l2_device in i2c-adapter driver_data, and provide their own i2c_board_info data, including a platform_data field. Add a v4l2_i2c_new_dev_subdev() API function that does exactly the same as v4l2_i2c_new_subdev() but uses different parameters, and make v4l2_i2c_new_subdev() a wrapper around it.

Quoted 5 lines

[snip]

I am wondering about this ongoing effort and its pursued goal: is it to hierarchize the v4l architecture, adding new abstraction levels? If so, what for?

Driver-reuse. soc-camera framework will be able to use all available and new v4l2-subdev drivers, and vice versa.

Quoted 3 lines

To me, as an eventual driver developer, this makes it harder to integrate my own drivers, as I use I2C and V4L in my system but I don't want them to be tightly coupled.

This conversion shouldn't make the coupling any tighter.

Quoted 3 lines

Of course I can ignore this "subdev" stuff and just link against soc-camera which is what I need, and manage I2C without V4L knowing about it. Which is what I do.

You won't be able to. The only link to woc-camera will be the v4l2-subdev link. Already now with this patch many essential soc-camera API operations are gone.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/