Skip to contentSkip to conversation

ARM: shmobile: smp: Enforce shmobile_smp_* alignment

PATCH Prabhakar Mahadev Lad 4 participants 7 messages Apr 16, 2025 – May 7, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi All,

Quoted 39 lines

From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

From: Geert Uytterhoeven <[email protected]>

commit 379c590113ce46f605439d4887996c60ab8820cc upstream.

When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails:

smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPU

Fix this by adding the missing alignment directive.

Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,

arg}[] from .text to .bss")

[email protected]

Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
[email protected]

---
Hi All,

Quoted 8 lines

Note:
- This issue has been replicated on 4.4-cip with older compilers and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
- The offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.

Gentle ping for review.

Cheers,
Prabhakar

Reviewed-by
#2 lore raw

Hi Prabhakar,

Sorry for review is too late.

Quoted 62 lines

-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Hi All,

Quoted 25 lines

From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

From: Geert Uytterhoeven <[email protected]>

commit 379c590113ce46f605439d4887996c60ab8820cc upstream.

When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails:

smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPU

Fix this by adding the missing alignment directive.

Quoted 8 lines
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,

arg}[] from .text to .bss")

[email protected]

Link:

https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416

Quoted 4 lines

1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad Prabhakar

<[email protected]>

Quoted 11 lines

---
Hi All,

Note:
- This issue has been replicated on 4.4-cip with older compilers and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
- The offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.

Quoted 2 lines

Gentle ping for review.

LGTM.

Best regards,
Nobuhiro

#3 lore raw

Hi Iwamatsu-san,

Quoted 76 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: 17 April 2025 07:05
To: Prabhakar Mahadev Lad <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Hi Prabhakar,

Sorry for review is too late.

Quoted 63 lines

-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Hi All,

Quoted 25 lines

From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

From: Geert Uytterhoeven <[email protected]>

commit 379c590113ce46f605439d4887996c60ab8820cc upstream.

When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails:

smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPU

Fix this by adding the missing alignment directive.

Quoted 8 lines
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr,

fn, arg}[] from .text to .bss")

[email protected]

Link:

https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416

Quoted 4 lines

1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad Prabhakar

<[email protected]>

Quoted 11 lines

---
Hi All,

Note:
- This issue has been replicated on 4.4-cip with older compilers and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
- The offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.

Quoted 7 lines
Quoted 2 lines

Gentle ping for review.

LGTM.

Thank you for the review. This patch is missing in 4.4-cip.

Cheers,
Prabhakar

#4 lore raw

Hi,

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

Gentle ping for review.

LGTM.

Thank you for the review. This patch is missing in 4.4-cip.

Perhaps Uli does not notice because he is not in TO and CC.

Uli, could you pick this patch to next 4.4.y-cip release?

Best regards.
Nobuhiro

Quoted 109 lines

-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Monday, April 28, 2025 4:40 AM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Hi Iwamatsu-san,

Quoted 11 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: 17 April 2025 07:05
To: Prabhakar Mahadev Lad <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Quoted 24 lines

Hi Prabhakar,

Sorry for review is too late.

Quoted 20 lines

-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Hi All,

Quoted 6 lines

From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek

<[email protected]>

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

From: Geert Uytterhoeven <[email protected]>

commit 379c590113ce46f605439d4887996c60ab8820cc upstream.

When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn,

and

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails:

smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPU

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Fix this by adding the missing alignment directive.

Fixes 4e960f52fce16a3b ("ARM: shmobile: Move

shmobile_smp_{mpidr,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

fn, arg}[] from .text to .bss")
Closes:

https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

[email protected]

Tested-by Lad Prabhakar

<[email protected]>

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

Link:

https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174

Quoted 17 lines
Quoted 17 lines

16

Quoted 4 lines

1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad Prabhakar

<[email protected]>

Quoted 11 lines

---
Hi All,

Note:
- This issue has been replicated on 4.4-cip with older compilers and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
- The offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.

Quoted 7 lines
Quoted 2 lines

Gentle ping for review.

LGTM.

Thank you for the review. This patch is missing in 4.4-cip.

Cheers,
Prabhakar

#5 lore raw
Quoted 10 lines · CEST Nobuhiro Iwamatsu via lists.cip-project.org
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Gentle ping for review.

LGTM.

Thank you for the review. This patch is missing in 4.4-cip.

Perhaps Uli does not notice because he is not in TO and CC.

Yes, please include me when sending patches for 4.4 and 4.19 kernels.

Quoted 1 line

Uli, could you pick this patch to next 4.4.y-cip release?

Can do. Am I correct to assume that this is specifically for -cip and does not apply to -st?

CU
Uli

#6 lore raw

Hi Ulrich,

Quoted 17 lines

-----Original Message-----
From: Ulrich Hecht <[email protected]>
Sent: 07 May 2025 09:45
To: [email protected]; Nobuhiro Iwamatsu via lists.cip- project.org <[email protected]>; Prabhakar Mahadev Lad <[email protected]>
Cc: Biju Das <[email protected]>; [email protected]; [email protected]
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

Quoted 1 line

On 05/07/2025 2:55 AM CEST Nobuhiro Iwamatsu via lists.cip-project.org

Quoted 3 lines · <[email protected]> wrote:
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

Gentle ping for review.

LGTM.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

Thank you for the review. This patch is missing in 4.4-cip.

Perhaps Uli does not notice because he is not in TO and CC.

Yes, please include me when sending patches for 4.4 and 4.19 kernels.

Sure, I will take care of it next time.

Quoted 5 lines
Quoted 1 line

Uli, could you pick this patch to next 4.4.y-cip release?

Can do. Am I correct to assume that this is specifically for -cip and does not apply to -st?

Yes for -cip, the offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only.

Cheers,
Prabhakar

Reviewed-by
#7 lore raw
In reply to Prabhakar Mahadev Lad

Hi!

Quoted 38 lines
Quoted 30 lines

From: Geert Uytterhoeven <[email protected]>

commit 379c590113ce46f605439d4887996c60ab8820cc upstream.

When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails:

smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPU

Fix this by adding the missing alignment directive.

Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,

arg}[] from .text to .bss")

[email protected]

Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
[email protected]

---
Hi All,

Quoted 8 lines

Note:
- This issue has been replicated on 4.4-cip with older compilers and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
- The offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.

Quoted 1 line

Gentle ping for review.

I could not find traces of the email in my mail archives. Strange.

Anyway, adding alignment is unlikely to hurt anything, and patch looks ok to me.

Best regards,
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany