ARM: shmobile: smp: Enforce shmobile_smp_* alignment
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi All,
Quoted 39 lines
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentFrom: Geert Uytterhoeven <[email protected]>
commit
379c590113ce46f605439d4887996c60ab8820ccupstream.When the addresses of the
shmobile_smp_mpidr,shmobile_smp_fn, andshmobile_smp_argvariables are not multiples of 4 bytes, secondary CPU bring-up fails:smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPUFix this by adding the missing alignment directive.
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,arg}[] from .text to .bss")
Signed-off-by Geert Uytterhoeven <[email protected]>Tested-by Lad Prabhakar <[email protected]>Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
[email protected]Signed-off-by Lad Prabhakar <[email protected]>---
Hi All,
Quoted 8 lines
Note:
- This issue has been replicated on 4.4-cip with older compilers andCONFIG_CC_OPTIMIZE_FOR_PERFORMANCEenabled.
- The offending commit4e960f52fce16a3bis not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.
Gentle ping for review.
Cheers,
Prabhakar
[email protected]
Reviewed-byHi Prabhakar,
Sorry for review is too late.
Quoted 62 lines
-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentHi All,
Quoted 25 lines
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentFrom: Geert Uytterhoeven <[email protected]>
commit
379c590113ce46f605439d4887996c60ab8820ccupstream.When the addresses of the
shmobile_smp_mpidr,shmobile_smp_fn, andshmobile_smp_argvariables are not multiples of 4 bytes, secondary CPU bring-up fails:smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPUFix this by adding the missing alignment directive.
Quoted 8 lines
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,arg}[] from .text to .bss")
Signed-off-by Geert Uytterhoeven <[email protected]>Tested-by Lad Prabhakar <[email protected]>Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416
Quoted 4 lines
1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad PrabhakarQuoted 11 lines
---
Hi All,Note:
- This issue has been replicated on 4.4-cip with older compilers andCONFIG_CC_OPTIMIZE_FOR_PERFORMANCEenabled.
- The offending commit4e960f52fce16a3bis not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.
Quoted 2 lines
Gentle ping for review.
LGTM.
Best regards,
Nobuhiro
Hi Iwamatsu-san,
Quoted 76 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: 17 April 2025 07:05
To: Prabhakar Mahadev Lad <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentHi Prabhakar,
Sorry for review is too late.
Quoted 63 lines
-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentHi All,
Quoted 25 lines
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentFrom: Geert Uytterhoeven <[email protected]>
commit
379c590113ce46f605439d4887996c60ab8820ccupstream.When the addresses of the
shmobile_smp_mpidr,shmobile_smp_fn, andshmobile_smp_argvariables are not multiples of 4 bytes, secondary CPU bring-up fails:smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPUFix this by adding the missing alignment directive.
Quoted 8 lines
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr,fn, arg}[] from .text to .bss")
Signed-off-by Geert Uytterhoeven <[email protected]>Tested-by Lad Prabhakar <[email protected]>Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416
Quoted 4 lines
1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad PrabhakarQuoted 11 lines
---
Hi All,Note:
- This issue has been replicated on 4.4-cip with older compilers andCONFIG_CC_OPTIMIZE_FOR_PERFORMANCEenabled.
- The offending commit4e960f52fce16a3bis not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.
Quoted 7 lines
Quoted 2 lines
Gentle ping for review.
LGTM.
Reviewed-by Nobuhiro Iwamatsu <[email protected]>
Thank you for the review. This patch is missing in 4.4-cip.
Cheers,
Prabhakar
Hi,
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
Gentle ping for review.
LGTM.
Reviewed-by Nobuhiro Iwamatsu <[email protected]>Thank you for the review. This patch is missing in 4.4-cip.
Perhaps Uli does not notice because he is not in TO and CC.
Uli, could you pick this patch to next 4.4.y-cip release?
Best regards.
Nobuhiro
Quoted 109 lines
-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Monday, April 28, 2025 4:40 AM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentHi Iwamatsu-san,
Quoted 11 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: 17 April 2025 07:05
To: Prabhakar Mahadev Lad <[email protected]>; [email protected]
Cc: Biju Das <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentQuoted 24 lines
Hi Prabhakar,
Sorry for review is too late.
Quoted 20 lines
-----Original Message-----
From: Prabhakar Mahadev Lad <[email protected]>
Sent: Wednesday, April 16, 2025 7:56 PM
To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT) <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>; Prabhakar Mahadev Lad <[email protected]>; [email protected]
Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentHi All,
Quoted 6 lines
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 04 April 2025 10:58
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel MachekQuoted 9 lines
Quoted 9 lines
Quoted 9 lines
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentFrom: Geert Uytterhoeven <[email protected]>
commit
379c590113ce46f605439d4887996c60ab8820ccupstream.When the addresses of the
shmobile_smp_mpidr,shmobile_smp_fn,and
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
shmobile_smp_argvariables are not multiples of 4 bytes, secondary CPU bring-up fails:smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPUQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Fix this by adding the missing alignment directive.
Fixes 4e960f52fce16a3b ("ARM: shmobile: Moveshmobile_smp_{mpidr,
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
fn, arg}[] from .text to .bss")
Closes:https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Geert Uytterhoeven <[email protected]>Tested-by Lad PrabhakarQuoted 3 lines
Quoted 3 lines
Quoted 2 lines
Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174
Quoted 17 lines
Quoted 17 lines
16
Quoted 4 lines
1220
[email protected]
Cc: [email protected]
Signed-off-by: Lad PrabhakarQuoted 11 lines
---
Hi All,Note:
- This issue has been replicated on 4.4-cip with older compilers andCONFIG_CC_OPTIMIZE_FOR_PERFORMANCEenabled.
- The offending commit4e960f52fce16a3bis not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.Quoted 7 lines
Quoted 2 lines
Gentle ping for review.
LGTM.
Reviewed-by Nobuhiro Iwamatsu <[email protected]>Thank you for the review. This patch is missing in 4.4-cip.
Cheers,
Prabhakar
Quoted 10 lines · CEST Nobuhiro Iwamatsu via lists.cip-project.org
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
Gentle ping for review.
LGTM.
Reviewed-by Nobuhiro Iwamatsu <[email protected]>Thank you for the review. This patch is missing in 4.4-cip.
Perhaps Uli does not notice because he is not in TO and CC.
Yes, please include me when sending patches for 4.4 and 4.19 kernels.
Quoted 1 line
Uli, could you pick this patch to next 4.4.y-cip release?
Can do. Am I correct to assume that this is specifically for -cip and does not apply to -st?
CU
Uli
Hi Ulrich,
Quoted 17 lines
-----Original Message-----
From: Ulrich Hecht <[email protected]>
Sent: 07 May 2025 09:45
To: [email protected]; Nobuhiro Iwamatsu via lists.cip- project.org <[email protected]>; Prabhakar Mahadev Lad <[email protected]>
Cc: Biju Das <[email protected]>; [email protected]; [email protected]
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignmentQuoted 1 line
On 05/07/2025 2:55 AM CEST Nobuhiro Iwamatsu via lists.cip-project.org
Quoted 3 lines · <[email protected]> wrote:
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Gentle ping for review.
LGTM.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Reviewed-by Nobuhiro Iwamatsu <[email protected]>Thank you for the review. This patch is missing in 4.4-cip.
Perhaps Uli does not notice because he is not in TO and CC.
Yes, please include me when sending patches for 4.4 and 4.19 kernels.
Sure, I will take care of it next time.
Quoted 5 lines
Quoted 1 line
Uli, could you pick this patch to next 4.4.y-cip release?
Can do. Am I correct to assume that this is specifically for -cip and does not apply to -st?
Yes for -cip, the offending commit 4e960f52fce16a3b is not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only.
Cheers,
Prabhakar
Pavel Machek
Reviewed-byHi!
Quoted 38 lines
Quoted 30 lines
From: Geert Uytterhoeven <[email protected]>
commit
379c590113ce46f605439d4887996c60ab8820ccupstream.When the addresses of the
shmobile_smp_mpidr,shmobile_smp_fn, andshmobile_smp_argvariables are not multiples of 4 bytes, secondary CPU bring-up fails:smp: Bringing up secondary CPUs ...
CPU1: failed to come online
CPU2: failed to come online
CPU3: failed to come online
smp: Brought up 1 node, 1 CPUFix this by adding the missing alignment directive.
Fixes 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,arg}[] from .text to .bss")
Signed-off-by Geert Uytterhoeven <[email protected]>Tested-by Lad Prabhakar <[email protected]>Link:
https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
[email protected]Signed-off-by Lad Prabhakar <[email protected]>---
Hi All,Quoted 8 lines
Note:
- This issue has been replicated on 4.4-cip with older compilers andCONFIG_CC_OPTIMIZE_FOR_PERFORMANCEenabled.
- The offending commit4e960f52fce16a3bis not present in v4.4 release so this patch wont be backported into 4.4-cip by stable hence just sending this for 4.4-cip only. Please note this patch has been cherry-picked v6.14 release.
Quoted 1 line
Gentle ping for review.
I could not find traces of the email in my mail archives. Strange.
Anyway, adding alignment is unlikely to hurt anything, and patch looks ok to me.
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany