Skip to contentSkip to conversation

apt: upgrade 2.6.1 -> 3.0.3

PATCH Gyorgy Sarvari 2 participants 2 messages Aug 28, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 12 lines · Gyorgy Sarvari via lists.openembedded.org
(quoted diff) +11 -0
+From a6b024ceb71c43977838d625f5ac64b7e4815a56 Mon Sep 17 00:00:00 2001
+From: Gyorgy Sarvari <[email protected]>
+Date: Thu, 28 Aug 2025 08:11:58 +0200
+Subject: [PATCH] fix compilation with musl
+
+The basename() function requires the libgen.h header when
+compiling with musl-libc, otherwise it complains:
+
+error: 'basename' was not declared in this scope; did you mean 'rename'?
+
+Also, musl's basename requires char* instead of const char* argument:

Review

Quoted 10 lines
(quoted diff) +10 -0
+
+error: invalid conversion from 'const char*' to 'char*' [-fpermissive]
+
+The musl implementation of basename modifies the argument only in case
+it is a folder path (it cuts off the trailing slashes). In our case,
+when argv[0] is passed, it is always a filename without a trailing
+slash, so just cast the argument.
+
+Upstream-Status: Pending [account registration in progress]
+Signed-off-by: Gyorgy Sarvari <[email protected]>

I plan to change the status of the Pending patch in the near future (once my Debian account is approved). Until then it's RFC in the worst case, I guess?

#2 lore raw
Quoted 7 lines · Gyorgy Sarvari via lists.openembedded.org

Review

Quoted 3 lines
(quoted diff) +2 -0
+Upstream-Status: Pending [account registration in progress]
+Signed-off-by: Gyorgy Sarvari <[email protected]>

I plan to change the status of the Pending patch in the near future (once my Debian account is approved). Until then it's RFC in the worst case, I guess?

Ongoing account registration is actually a valid reason for Pending status, and so the patch is fine. It's Pending without explanation which is very disliked.

Alex