Skip to contentSkip to conversation

runqemu: fix snapshot status log format

PATCH Gyorgy Sarvari 2 participants 2 messages Sep 2, 2025 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Please ignore this patch. It seems to work on EndeavourOS fine, but my Debian12 system complains about syntax error.

Quoted 42 lines · Gyorgy Sarvari via lists.openembedded.org

The snapshot status is diisplayed incorrectly, in case snasphot is disabled.

Enabled state:
SNAPSHOT: [Enabled. Changes on rootfs won't be kept after QEMU shutdown.]

Disabled state:
Disabled. Changes on rootfs will be kept after QEMU shutdown.

Fix the log output to make them have the same format.

---
 scripts/runqemu | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
scripts/runqemu +4 -4
index 827300080a..fd61f3b605 100755
@@ -1054,9 +1054,10 @@ to your build configuration.
             logoutput.append('NFS_DIR: [%s]' % self.rootfs)
         else:
             logoutput.append('ROOTFS: [%s]' % self.rootfs)
-        logoutput.append('SNAPSHOT: [%s]' %
-                         "Enabled. Changes on rootfs won't be kept after QEMU shutdown." if self.snapshot
-                         else "Disabled. Changes on rootfs will be kept after QEMU shutdown.")
+
+        logoutput.append(f'SNAPSHOT: [{"Enabled. Changes on rootfs won't be kept after QEMU shutdown." if self.snapshot 
+                         else "Disabled. Changes on rootfs will be kept after QEMU shutdown."}]')
+
         if self.ovmf_bios:
             logoutput.append('OVMF: %s' % self.ovmf_bios)
         if (self.ovmf_secboot_pkkek1):
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#222667): https://lists.openembedded.org/g/openembedded-core/message/222667
Mute This Topic: https://lists.openembedded.org/mt/115010156/6084445
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 3 lines · Gyorgy Sarvari via lists.openembedded.org

Please ignore this patch. It seems to work on EndeavourOS fine, but my Debian12 system complains about syntax error.

Too late! :)
Yes, I confirm Python is not happy at all with the quotes in there.

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com