Skip to contentSkip to conversation

riscv: remove unused barrier defines

PATCH Rolf Eike Beer 2 participants 2 messages Jun 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <[email protected]>
Date: Mon, 17 Jun 2019 14:22:37 +0200
Subject: [PATCH] riscv: remove unused barrier defines

They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long after 2e39465abc4b7856a0ea6fcf4f6b4668bb5db877 removed the remnants of all previous instances from the tree.

---
 arch/riscv/include/asm/bitops.h | 5 -----
 1 file changed, 5 deletions(-)
arch/riscv/include/asm/bitops.h +0 -5
index 3943be480af0..396a3303c537 100644
@@ -15,11 +15,6 @@
 #include <asm/barrier.h>
 #include <asm/bitsperlong.h>
 
-#ifndef smp_mb__before_clear_bit
-#define smp_mb__before_clear_bit()  smp_mb()
-#define smp_mb__after_clear_bit()   smp_mb()
-#endif /* smp_mb__before_clear_bit */
-
 #include <asm-generic/bitops/__ffs.h>
 #include <asm-generic/bitops/ffz.h>
 #include <asm-generic/bitops/fls.h>
Signature · 9 lines
2.21.0
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source
#1 lore raw
Quoted 10 lines · Rolf Eike Beer

From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <[email protected]>
Date: Mon, 17 Jun 2019 14:22:37 +0200
Subject: [PATCH] riscv: remove unused barrier defines

They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long after 2e39465abc4b7856a0ea6fcf4f6b4668bb5db877 removed the remnants of all previous instances from the tree.

Thanks for the patch. checkpatch.pl flags an error on the format of the commit IDs in the patch description. And there is also the spurious mbox header. These have been fixed these up here, and the patch below has been queued for v5.2-rc. It would help to run "checkpatch.pl --strict" on future patches.

thanks again,

- Paul

From: Rolf Eike Beer <[email protected]>
Date: Mon, 17 Jun 2019 14:25:59 +0200
Subject: [PATCH] riscv: remove unused barrier defines

They were introduced in commit fab957c11efe ("RISC-V: Atomic and Locking Code") long after commit 2e39465abc4b ("locking: Remove deprecated smp_mb__() barriers") removed the remnants of all previous instances from the tree.

[[email protected]: stripped spurious mbox header from patch
description; fixed commit references in patch header]

---
 arch/riscv/include/asm/bitops.h | 5 -----
 1 file changed, 5 deletions(-)
arch/riscv/include/asm/bitops.h +0 -5
index f30daf26f08f..01db98dfd043 100644
@@ -23,11 +23,6 @@
 #include <asm/barrier.h>
 #include <asm/bitsperlong.h>
 
-#ifndef smp_mb__before_clear_bit
-#define smp_mb__before_clear_bit()  smp_mb()
-#define smp_mb__after_clear_bit()   smp_mb()
-#endif /* smp_mb__before_clear_bit */
-
 #include <asm-generic/bitops/__ffs.h>
 #include <asm-generic/bitops/ffz.h>
 #include <asm-generic/bitops/fls.h>
Signature · 1 line
2.20.1