Skip to contentSkip to conversation

gstreamer1.0-plugins-bad: add ANY_OF_DISTRO_FEATURES

PATCH In review Changqing Li 2 participants 3 messages Apr 15 – May 7 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v3 1/1 gstreamer1.0-plugins-bad: add ANY_OF_DISTRO_FEATURES

When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
do_configure will failed with error:
gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work

when vulkan is enabled in DISTRO_FEATURES, set ANY_OF_DISTRO_FEATURES to x11 or wayland to skip building of gstreamer1.0-plugins-bad

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb             | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb +4 -1
index cdf3a20dff..aabcafe121 100644
@@ -19,7 +19,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
 DEPENDS += "gstreamer1.0-plugins-base"
 
-inherit gobject-introspection
+inherit gobject-introspection features_check
+
+# When vulkan is enabled, at least one of x11 or wayland is needed
+ANY_OF_DISTRO_FEATURES = "${@bb.utils.contains('DISTRO_FEATURES', 'vulkan', 'x11 wayland', '', d)}"
 
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
Signature · 1 line
2.34.1
#2 lore raw
Quoted 7 lines · Changqing Li via lists.openembedded.org

When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
do_configure will failed with error:
gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work

when vulkan is enabled in DISTRO_FEATURES, set ANY_OF_DISTRO_FEATURES to x11 or wayland to skip building of gstreamer1.0-plugins-bad

It’s absolutely fine to enable vulkan but not x11/wayland (because you’re doing vulkan to raw buffers, or using vulkan for compute) so I don’t think this combination should cause the entire recipe to fail just because the vulkansink needs vulkan+display backend.

Ideally, the PACKAGECONFIG is only enabled if vulkan && (x11 || wayland) DISTRO_FEATURES are enabled, but that’s going to be quite a long line in the recipe until we have a version of bb.utils.contains() that can do logic.

I think the better solution is that distros who want to do this just do PACKAGECONFIG:remove = “vulkan” for this recipe.

Ross

#3 lore raw
Quoted 8 lines · Ross Burton

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 4 lines · Changqing Li via lists.openembedded.org

When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
do_configure will failed with error:
gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work

Quoted 7 lines
Quoted 2 lines

when vulkan is enabled in DISTRO_FEATURES, set ANY_OF_DISTRO_FEATURES to x11 or wayland to skip building of gstreamer1.0-plugins-bad

It’s absolutely fine to enable vulkan but not x11/wayland (because you’re doing vulkan to raw buffers, or using vulkan for compute) so I don’t think this combination should cause the entire recipe to fail just because the vulkansink needs vulkan+display backend.

Ideally, the PACKAGECONFIG is only enabled if vulkan && (x11 || wayland) DISTRO_FEATURES are enabled, but that’s going to be quite a long line in the recipe until we have a version of bb.utils.contains() that can do logic.

I think the better solution is that distros who want to do this just do PACKAGECONFIG:remove = “vulkan” for this recipe.

Hi, Ross

Thanks.  I resend a patch to try remove vulkan in this recipe.

//Changqing

Quoted 1 line

Ross