Skip to contentSkip to conversation

Split vim and xxd in different recipes

PATCH Joao Marcos Costa 2 participants 2 messages May 20 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hello,

Quoted 30 lines · Joao Marcos Costa via lists.openembedded.org

Hello,

Honestly, my main motivation to send this series comes from a time when I was building u-boot (meta-freescale) and I saw vim-native in Bitbake's tasks. It blew my mind that a bootloader somehow dependend on a text editor (yes, only to be built, not to be executed, I know), and the whole text editor was being built to provide nothing more than xxd.

Just to be clear, what bothers me is NOT u-boot depending on xxd. It is actually configuring and compiling Vim (considering the overhead this represents) only to use a single tiny piece of it.

As for the tests I performed:

- machine: qemuriscv64
- toolchains: clang and gcc
- classes (xxd, vim-xxd): target, native, nativesdk
- classes (vim): target, native, nativesdk

Everything built fine, and the core-image-minimal running with qemu also correctly shipped vim and xxd, which executed fine as well.

Best regards,

João Marcos Costa (4):
vim: introduce vim-sources.inc file
vim-xxd: introduce new recipe for xxd
vim: drop references to xxd in base recipe vim.inc: remove xxd from the destination directory

Quoted 8 lines
  meta/conf/distro/include/maintainers.inc |  1 +
  meta/recipes-support/vim/vim-sources.inc | 16 +++++++++++++
  meta/recipes-support/vim/vim-xxd_9.2.bb  | 29 ++++++++++++++++++++++++
  meta/recipes-support/vim/vim.inc         | 21 ++++-------------
  meta/recipes-support/vim/vim_9.2.bb      | 10 --------
  5 files changed, 51 insertions(+), 26 deletions(-)

create mode 100644 meta/recipes-support/vim/vim-sources.inc create mode 100644 meta/recipes-support/vim/vim-xxd_9.2.bb

Would there be any more feedbacks on this series? So far, I have been considering to prepare a v2 to fix the License issue mentioned by Ross, and also wiping out the source code of vim in vim-xxd_9.2.bb (leaving only xxd's code, of course). This step would significantly reduce the risk of xxd being affected by Vim's CVEs.

However, I prefer not investing my time on it if this split is not seriously considered in the first place.

Thanks!

Signature · 2 lines
Best regards,
João Marcos Costa
#2 lore raw
Quoted 8 lines · Joao Marcos Costa via lists.openembedded.org

Would there be any more feedbacks on this series? So far, I have been considering to prepare a v2 to fix the License issue mentioned by Ross, and also wiping out the source code of vim in vim-xxd_9.2.bb (leaving only xxd's code, of course). This step would significantly reduce the risk of xxd being affected by Vim's CVEs.

However, I prefer not investing my time on it if this split is not seriously considered in the first place.

I would appreciate a v2, so we can seriously consider dropping vim proper from core as the next step. The reasons are in oe-architecture list, if anyone wants to pick up the discussion.

Alex