Skip to contentSkip to conversation

meta: Add pam to the defaults if using systemd

PATCH Leon Anavi 1 participant 1 message Jul 3 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Leon Anavi

author
#1 lore raw

Hi,

Please note that, if accepted, this patch should be cherry-picked to Wrynose as well.

Sharing some context and feedback regarding these yocto-check-layer failures:

I submitted this patch because the recent changes mentioned in the commit cause test_machine_world to fail when running yocto-check-layer on the meta-tegra BSP layer. This regression subsequently broke the private commercial layer I am working on with the exact same error.

I am using the yocto-check-layer script to assess how compatible our private commercial layers are with the Yocto Project. However, in this case using yocto-check-layer has become a bit pesky with issues like this, alongside the requirement that the layer under test cannot be present in BBLAYERS and that the layer's dependencies must be specified with the --dependency argument.

Best regards, Leon

Quoted 55 lines · Leon Anavi via lists.openembedded.org

Add pam to the list of DISTRO_FEATURES_DEFAULTS if variable VIRTUAL-RUNTIME_init_manager has been set to systemd. Otherwise having systemd in conjunction with wayland but without pam leads to a conflict with the REQUIRED_DISTRO_FEATURES for weston related recipes.

This adjustment is required following these recent changes that switched VIRTUAL-RUNTIME_init_manager to systemd by default and added wayland to DISTRO_FEATURES_DEFAULTS which affects "nodistro":

- 159148f4de2595556fef6e8678578df83383857b
meta: Support opting out of any distro features
(Please note that this commit also extended DISTRO_FEATURES_DEFAULTS with wayland and vulkan.)

- 0b4061c5d50261f826d0edb4b478d2d305274b7c
conf: Switch to systemd by default and simplify init manager selection

This fixes issues with test_machine_world when running the yocto-check-layer script for BSP layers that include weston in the dependency chain, for example meta-tegra:

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers. Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'l4t-graphics-demos', 'weston']

The weston recipe has pam in REQUIRED_DISTRO_FEATURES if systemd is enabled. Therefore, it makes sense to also add pam to the defaults through DISTRO_FEATURES_DEFAULTS.

---
  meta/conf/distro/include/default-distrovars.inc | 1 +
  1 file changed, 1 insertion(+)
meta/conf/distro/include/default-distrovars.inc +1 -1
index 69c6db589b..2eadfcbd74 100644
@@ -29,6 +29,7 @@ DISTRO_FEATURES_DEFAULTS ?= " \
      acl alsa bluetooth debuginfod ext2 ipv4 ipv6 \
      wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp pulseaudio \
      gobject-introspection-data ldconfig opengl ptest multiarch wayland vulkan \
+    ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'systemd', 'pam', '', d)} \
      "
  IMAGE_FEATURES ?= ""
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#240113): https://lists.openembedded.org/g/openembedded-core/message/240113
Mute This Topic: https://lists.openembedded.org/mt/120100403/2167311
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-