Skip to contentSkip to conversation

kernel-devsrc: drop unused scripts/mksysmap to avoid sed dependency

PATCH Roshan Sivakumar 2 participants 2 messages Nov 4 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Could someone review this patch? @Alexander<mailto:[email protected]>, @Bruce<mailto:[email protected]>, @Peter<mailto:[email protected]>

Thanks,

Roshan.

________________________________
From: Roshan Sivakumar via openembedded-core <[email protected]>
Sent: Monday, November 2, 2026 09:13
To: [email protected] <[email protected]>
Cc: Alexander Kanavin <[email protected]>; Peter Kjellerstedt <[email protected]>; Sumanth Gavini <[email protected]>; Bruce Ashfield <[email protected]>; Roshan Sivakumar <[email protected]>
Subject: [OE-core][PATCH] kernel-devsrc: drop unused scripts/mksysmap to avoid sed dependency

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

scripts/mksysmap is a '#!/bin/sed -f' script that is consumed only by scripts/link-vmlinux.sh during a full vmlinux link (NM | sed -f mksysmap

Quoted 1 line

System.map). External module builds against kernel-devsrc never relink

vmlinux, so the script is never used in this package.

Because it is packaged with a '#!/bin/sed' shebang, the RPM 6 interpreter dependency generator emits "Requires: /bin/sed" for kernel-devsrc. Only full GNU sed provides /bin/sed (busybox provides /usr/bin/sed), so SDK population fails with "nothing provides /bin/sed" on images using busybox sed.

Remove the script in do_install, mirroring the existing removal of scripts/package/debian/rules (dropped to avoid an RDEPENDS on make). This clears the spurious /bin/sed dependency without pulling full sed into the package or the SDK.

Assisted-by Claude Code:claude-opus-4.8
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +7 -0
index 90bdbfc534..7da7e270c3 100644
@@ -158,6 +158,13 @@ do_install() {
         # Remove as we else would ned to RDEPEND on make
         rm $kerneldir/build/scripts/package/debian/rules 2>/dev/null || :
 
+        # scripts/mksysmap is a '#!/bin/sed -f' script that is only consumed by
+        # scripts/link-vmlinux.sh during a full vmlinux link. External module
+        # builds never relink vmlinux, so it is unused here. Remove it as otherwise
+        # we would need to pull sed into the package/SDK to satisfy
+        # the dependency generated via the RPM shebang dependency generator (Requires: /bin/sed).
+        rm $kerneldir/build/scripts/mksysmap 2>/dev/null || :
+
         # tools/include is needed by the archscripts host tools that
         # 'make scripts prepare' rebuilds on target (e.g. x86 vdso2c) and
        # not checked against objtool as it previously was.

--
2.34.1

#2 lore raw

Please do not ping people for review, especially less than 48 hours after the patch was posted. If no one has anything to say, they will not clutter the mailing list with 'lgtm'. The patch will move through the standard review process as usual (CI pipeline, patch review meetings), and you'll hear if something needs to be addressed, otherwise it will merge quietly.

Alex

Quoted 73 lines · Roshan Sivakumar

Could someone review this patch? @Alexander <[email protected]>, @Bruce <[email protected]>, @Peter <[email protected]>

Thanks,

Roshan.

------------------------------
*From:* Roshan Sivakumar via openembedded-core <roshs= [email protected]>
*Sent:* Monday, November 2, 2026 09:13
*To:* [email protected] < [email protected]>
*Cc:* Alexander Kanavin <[email protected]>; Peter Kjellerstedt < [email protected]>; Sumanth Gavini <[email protected]>; Bruce Ashfield <[email protected]>; Roshan Sivakumar < [email protected]>
*Subject:* [OE-core][PATCH] kernel-devsrc: drop unused scripts/mksysmap to avoid sed dependency

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

scripts/mksysmap is a '#!/bin/sed -f' script that is consumed only by scripts/link-vmlinux.sh during a full vmlinux link (NM | sed -f mksysmap

Quoted 1 line

System.map). External module builds against kernel-devsrc never relink

vmlinux, so the script is never used in this package.

Because it is packaged with a '#!/bin/sed' shebang, the RPM 6 interpreter dependency generator emits "Requires: /bin/sed" for kernel-devsrc. Only full GNU sed provides /bin/sed (busybox provides /usr/bin/sed), so SDK population fails with "nothing provides /bin/sed" on images using busybox sed.

Remove the script in do_install, mirroring the existing removal of scripts/package/debian/rules (dropped to avoid an RDEPENDS on make). This clears the spurious /bin/sed dependency without pulling full sed into the package or the SDK.

Assisted-by Claude Code:claude-opus-4.8
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -0
index 90bdbfc534..7da7e270c3 100644
@@ -158,6 +158,13 @@ do_install() {
         # Remove as we else would ned to RDEPEND on make
         rm $kerneldir/build/scripts/package/debian/rules 2>/dev/null || :
 
+        # scripts/mksysmap is a '#!/bin/sed -f' script that is only

consumed by
+ # scripts/link-vmlinux.sh during a full vmlinux link. External
module
+ # builds never relink vmlinux, so it is unused here. Remove it as
otherwise

meta/recipes-kernel/linux/kernel-devsrc.bb +2 -0
+        # we would need to pull sed into the package/SDK to satisfy
+        # the dependency generated via the RPM shebang dependency

generator (Requires: /bin/sed).

meta/recipes-kernel/linux/kernel-devsrc.bb +2 -1
+        rm $kerneldir/build/scripts/mksysmap 2>/dev/null || :
+
         # tools/include is needed by the archscripts host tools that
         # 'make scripts prepare' rebuilds on target (e.g. x86 vdso2c) and
        # not checked against objtool as it previously was.
--

2.34.1