Skip to contentSkip to conversation

drm/mcde: dsi: Fix a return value check in mcde_dsi_bind()

PATCH Markus Elfring 1 participant 1 message Apr 28, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

In case of error, the function of_drm_find_bridge() returns NULL pointer not ERR_PTR().

Such information is helpful.

Quoted 2 lines

The IS_ERR() test in the return value check should be replaced with NULL test.

* Would you like to convert this description into an imperative wording?

* Please fix the patch subject according to a function name.

* How do you think about to add the tag “Fixes” to the commit message because of an adjustment for the error detection?

Regards,
Markus