Skip to contentSkip to conversation

drivers/ras/debugfs.c - add missing #includes

PATCH New Valdis Kl=?utf-8?Q?=c4=93?=tnieks 1 participant 1 message Mar 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/ras/debugfs.c - add missing #includes

Building with C=2 W=1 reports:

CHECK drivers/ras/debugfs.c
drivers/ras/debugfs.c:3:15: warning: symbol 'ras_debugfs_dir' was not declared. Should it be static? drivers/ras/debugfs.c:7:5: warning: symbol 'ras_userspace_consumers' was not declared. Should it be static? drivers/ras/debugfs.c:37:12: warning: symbol 'ras_add_daemon_trace' was not declared. Should it be static? drivers/ras/debugfs.c:53:13: warning: symbol 'ras_debugfs_init' was not declared. Should it be static?
CC drivers/ras/debugfs.o
drivers/ras/debugfs.c:7:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
7 | int ras_userspace_consumers(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:37:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
37 | int __init ras_add_daemon_trace(void)

      |            ^~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:53:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
   53 | void __init ras_debugfs_init(void)
      |             ^~~~~~~~~~~~~~~~

And indeed, there's 2 missing #include's.

drivers/ras/debugfs.c +2 -0
index 501603057dff..12a161377f4f 100644
@@ -1,4 +1,6 @@
 #include <linux/debugfs.h>
+#include <linux/ras.h>
+#include "debugfs.h"
 
 struct dentry *ras_debugfs_dir;