cmd640 irqlocking fixes

RFC/CFT Petr Vandrovec 3 participants 3 messages Jul 25, 2002 – Jul 26, 2002

lore

Share & tools

lore

Petr Vandrovec

author

2002-07-25 12:48 UTC #0 lore raw

Review

Quoted 4 lines · Alan Cox

(quoted diff) +4 -0

+   OUT_BYTE(0x00, 0xCFB);
+   OUT_BYTE(0x00, 0xCF8);
+   OUT_BYTE(0x00, 0xCFA);
+   if (IN_BYTE(0xCF8) == 0x00 && IN_BYTE(0xCF8) == 0x00) {

                                            ^^^^^

It should be 0xCFA according to arch/i386/pci/direct.c...
Petr Vandrovec [email protected]

Alan Cox

2002-07-25 13:20 UTC #1 lore raw

Quoted 8 lines · Petr Vandrovec

Review

Quoted 4 lines · Alan Cox

(quoted diff) +4 -0

+   OUT_BYTE(0x00, 0xCFB);
+   OUT_BYTE(0x00, 0xCF8);
+   OUT_BYTE(0x00, 0xCFA);
+   if (IN_BYTE(0xCF8) == 0x00 && IN_BYTE(0xCF8) == 0x00) {

                                            ^^^^^

It should be 0xCFA according to arch/i386/pci/direct.c...

Correct. Martin I agree with this change.

Marcin Dalecki

2002-07-26 04:52 UTC #2 lore raw

Quoted 10 lines · Alan Cox

Quoted 8 lines · Petr Vandrovec
Quoted 4 lines · Alan Cox
(quoted diff) +4 -0
+   OUT_BYTE(0x00, 0xCFB);
+   OUT_BYTE(0x00, 0xCF8);
+   OUT_BYTE(0x00, 0xCFA);
+   if (IN_BYTE(0xCF8) == 0x00 && IN_BYTE(0xCF8) == 0x00) {

Quoted 5 lines

Quoted 2 lines
                                           ^^^^^
It should be 0xCFA according to arch/i386/pci/direct.c...
Correct. Martin I agree with this change.

Thanks. I noted it already.