Skip to contentSkip to conversation

Recommendation: [PATCH] SIS AGP 648[FX] cleaned+fixed ...

DISCUSSION Oliver Schoett 1 participant 2 messages Feb 19, 2004 – Apr 17, 2004 6 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 2 lines · Oliver

This patch is provides AGP support for sis 648 and 648FX chipsets (previous versions only worked on FX chipsets).

I would like to point out how important this patch is. My Motherboard (Microstar MS-6701, branded MD-5000) has a SIS 648 north bridge, and for months before the patch, I have observed the following: on a freshly booted system, after

insmod agpgart
insmod sis-agp
insmod fglrx (the binary kernel module from ATI)
/etc/init.d/xdm start (start X server)

the machine would always lock up completely: black screen, no IDE disk I/O, no Ctrl-Alt-Backsp or Ctrl-Alt-F1, only the SysRq keys worked. I have actually lost data due to the blocked disk I/O when experimenting with this. The problem has been consistent for the entire 2.6.0-test* and 2.6.* kernel series and for various versions of the binary ATI drivers for my ATI 9600TX graphics card.

The patch by Oliver Heilmann makes the above process work flawlessly on my machine on kernels 2.6.2 and 2.6.3, and with variations such als letting sis-agp pull in agpgart and letting the X server pull in the fglrx module.

(Actually, for my SIS 648 chip, just the 10ms timeout is enough, but I have read reports on the gentoo board by SIS 648FX owners that the patch turned their graphics cards from not working to working with DRI for the first time.)

This patch is an important contribution for owners of the common SIS 648 and SIS 648FX north bridge chips, and I therefore recommend it for inclusion in the kernel AGP driver.

Regards,

Oliver Schoett

#7 lore raw

Re: AGP problem SiS 746FX Linux 2.6.5-rc3

In reply to a message not in the archive
Quoted 9 lines · Dave Jones

Ok, so your system is fully AGP v3 compliant, (both host and gfx card). The missing check highlighted in your diff means that we only do AGPv3 stuff if we have an AGP 3.5 host bridge. You have a 3.0 bridge, so it was falling back to AGP v2. My suspicion now is that the 648 and 746 chipsets vary too much for them to both use the generic routines, so I'll reinstate the check. It'll still report that it finds an AGP v3.0 device, but until someone comes forward with chipset docs, it looks like it'll be limited to AGP v2. (I'm amazed that it works at all, really).

Here is some information about the AGP mode checks I learned from Oliver Heilmann: The two chipsets SiS 648 and SiS 648FX both have the chipset ID 0x0648, but need different initalisation code. The way to distinguish them is that the 648FX reports itself as AGP v3.5 capable, while the 648 reports itself as AGP v3.0 capable. This is handled correctly in Heilmann's patch in his Article <[email protected]> Date: Thu, 12 Feb 2004 00:10:08 +0100:

+static void __devinit sis_get_driver(struct agp_bridge_data *bridge) +{
+ if(bridge->dev->device==PCI_DEVICE_ID_SI_648)
+ {
+ if(agp_bridge->major_version==3 && agp_bridge->minor_version < 5)
+ {
+ sis_driver.agp_enable=sis_648_enable;
+ }
+ else
+ {
+ sis_driver.agp_enable = sis_648_enable;
+ sis_driver.aperture_sizes = agp3_generic_sizes;
+ sis_driver.size_type = U16_APER_SIZE;
+ sis_driver.num_aperture_sizes = AGP_GENERIC_SIZES_ENTRIES;
+ sis_driver.configure = agp3_generic_configure;
+ sis_driver.fetch_size = agp3_generic_fetch_size;
+ sis_driver.cleanup = agp3_generic_cleanup;
+ sis_driver.tlb_flush = agp3_generic_tlbflush;
+ }
+ }
+ bridge->driver=&sis_driver;
+}
+

Please preserve this distinction in your patch and don't degrade the SiS 648 chipset to AGP 2.0 (currently, 2.6.5 runs fine with AGP 3.0 on my SiS 648 chipset).

By the way, I noticed an oddity in the changeset
http://linux.bkbits.net:8080/linux-2.5/[email protected]: the line

- set_current_state(TASK_INTERRUPTIBLE);

becomes

+ set_current_state(TASK_UNINTERRUPTIBLE);

Which of the two settings is correct?

Regards,

Oliver Schoett