archive-zip: refactor 'path too long' error message to use Q_()
PATCH v2 1/1 archive-zip: refactor 'path too long' error message to use Q_()
In reply to a message not in the archiveFrom: Keryle Fondji <[email protected]>
Replace _() with Q_() in the 'path too long' error message. Although pathlen is always greater than 0xffff when this error is hit, Q_() is required to support correct translation for languages that require different plural forms depending on the count.
--- archive-zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
archive-zip.c +1 -1
@@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, }if (pathlen >0xffff ) { -return error (_ ("path too long (%d chars, SHA1: %s): %s" ), +return error (Q_ ("path too long (%d char, SHA1: %s): %s" ,"path too long (%d chars, SHA1: %s): %s" , pathlen), (int )pathlen,oid_to_hex (oid), path); }
Signature · 1 line
2.53.0
Hi Keryle
Quoted 6 lines · On 19/10/2026 16:27, [email protected] wrote:
From: Keryle Fondji <[email protected]>
Replace
_()withQ_()in the 'path too long' error message. Although pathlen is always greater than0xffffwhen this error is hit,Q_()is required to support correct translation for languages that require different plural forms depending on the count.
This is good. As Junio has pointed out the code needs wrapping now that it is using Q_().
Thanks
Phillip
Quoted 18 lines
Signed-off-by Keryle Fondji <[email protected]>--- archive-zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)archive-zip.c +1
-1@@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, }if (pathlen >0xffff ) { -return error (_ ("path too long (%d chars, SHA1: %s): %s" ), +return error (Q_ ("path too long (%d char, SHA1: %s): %s" ,"path too long (%d chars, SHA1: %s): %s" , pathlen), (int )pathlen,oid_to_hex (oid), path); }