Skip to contentSkip to conversation

io_uring: don't unconditionally set plug->nowait = true

PATCH New Jens Axboe 1 participant 1 message Sep 25, 2020

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: don't unconditionally set plug->nowait = true

This causes all the bios to be submitted with REQ_NOWAIT, which can be problematic on either btrfs or on file systems that otherwise use a mix of block devices where only some of them support it.

For now, just remove the setting of plug->nowait = true.

Fixes b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")

---

fs/io_uring.c +0 -3
index 0ab16df31288..ad828fa19af4 100644
@@ -6353,9 +6353,6 @@ static void io_submit_state_start(struct io_submit_state *state,
 				  struct io_ring_ctx *ctx, unsigned int max_ios)
 {
 	blk_start_plug(&state->plug);
-#ifdef CONFIG_BLOCK
-	state->plug.nowait = true;
-#endif
 	state->comp.nr = 0;
 	INIT_LIST_HEAD(&state->comp.list);
 	state->comp.ctx = ctx;
Signature · 1 line
Jens Axboe