Skip to contentSkip to conversation

Drop Kconfig option PCIEASPM?

DISCUSSION Heiner Kallweit 3 participants 4 messages Oct 25, 2019 – Oct 28, 2019 PCI

lore
Share & tools
lore
#0 lore raw

I wonder whether anybody actually wants to disable ASPM support. In an old Kconfig commit message is mentioned that it may help to reduce kernel size of embedded systems. However I would think that on embedded systems ASPM is quite useful as it saves significant power and may result in a lower system temperature therefore.
W/o ASPM support we have to live with devices coming up in whatever mode boot loader or firmware configure.

Heiner

#1 lore raw
Quoted 11 lines · Heiner Kallweit

I wonder whether anybody actually wants to disable ASPM support. In an old Kconfig commit message is mentioned that it may help to reduce kernel size of embedded systems. However I would think that on embedded systems ASPM is quite useful as it saves significant power and may result in a lower system temperature therefore.
W/o ASPM support we have to live with devices coming up in whatever mode boot loader or firmware configure.

Heiner

It means that we can still have an option to specify one of PCIEASPM_DEFAULT/PERFORMANCE/POWERSAVE/POWER_SUPERSAVE configs right?

Vidya Sagar

#2 lore raw
Quoted 10 lines · Vidya Sagar
Quoted 9 lines · Heiner Kallweit

I wonder whether anybody actually wants to disable ASPM support. In an old Kconfig commit message is mentioned that it may help to reduce kernel size of embedded systems. However I would think that on embedded systems ASPM is quite useful as it saves significant power and may result in a lower system temperature therefore.
W/o ASPM support we have to live with devices coming up in whatever mode boot loader or firmware configure.

Quoted 5 lines
Quoted 2 lines

Heiner

It means that we can still have an option to specify one of PCIEASPM_DEFAULT/PERFORMANCE/POWERSAVE/POWER_SUPERSAVE configs right?

Yes, these config options would remain.
PCIEASPM has a dependency on PCIEPORTBUS, so the idea would be to build ASPM support whenever PCIEPORTBUS is defined.

Quoted 2 lines

Vidya Sagar

Heiner

#3 lore raw
In reply to Heiner Kallweit
Quoted 8 lines · Heiner Kallweit

I wonder whether anybody actually wants to disable ASPM support. In an old Kconfig commit message is mentioned that it may help to reduce kernel size of embedded systems. However I would think that on embedded systems ASPM is quite useful as it saves significant power and may result in a lower system temperature therefore.
W/o ASPM support we have to live with devices coming up in whatever mode boot loader or firmware configure.

What would be the advantage of dropping CONFIG_PCIEASPM? I don't think it really costs us much to keep it. I do agree most systems probably want it.