Skip to contentSkip to conversation

newlines in message macros

DISCUSSION Bob Pearson 4 participants 6 messages Sep 13, 2023 – Sep 15, 2023 InfiniBand

lore
Share & tools
lore
#0 lore raw

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But, for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent and make them all the same. (Maybe they don't get used much or at all.)

Bob

#1 lore raw
Quoted 7 lines · Bob Pearson

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But, for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent and make them all the same. (Maybe they don't get used much or at all.)

Bob

On closer examination about half the debug messages that should have newlines added don't. About equally easy to fix this mess by reverting the change and/or removing or adding newlines as needed.

Which way should we go.

Bob

#2 lore raw
In reply to Bob Pearson
Quoted 3 lines · Bob Pearson

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,

I made tests for many times about adding newline speeding up flush messages. With or without new line, I can not find out the difference on flushing messages. Not sure if Li Zhijian found this difference in a specific scenario or not. And even without new line, after output the line, the message still goes to a new line. I suspect if a newline is appended in the PRINTK subsystem.

Zhu Yanjun

Quoted 4 lines

for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent and make them all the same. (Maybe they don't get used much or at all.)

Bob

#3 lore raw
Quoted 5 lines · Zhu Yanjun
Quoted 3 lines · Bob Pearson

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,

Quoted 7 lines

I made tests for many times about adding newline speeding up flush messages. With or without new line, I can not find out the difference on flushing messages. Not sure if Li Zhijian found this difference in a specific scenario or not.
And even without new line, after output the line, the message still goes to a new line. I suspect if a newline is appended in the PRINTK subsystem.

Kernel standard is to have newlines in the format strings.

Jason

#4 lore raw
In reply to Zhu Yanjun

Yanjun,

Quoted 7 lines · Zhu Yanjun
Quoted 3 lines · Bob Pearson

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,

I made tests for many times about adding newline speeding up flush messages. With or without new line, I can not find out the difference on flushing messages. Not sure if Li Zhijian found this difference in a specific scenario or not. And even without new line, after output the line, the message still goes to a new line. I suspect if a newline is appended in the PRINTK subsystem.

When i'm using something like: dmesg --follow monitor the dmesg, I can notice that delay clearly. you will see that the timestamp is correct, but the messages don't appear until a next newline.

Thanks
Zhijian

Quoted 8 lines

Zhu Yanjun

Quoted 4 lines

for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent and make them all the same. (Maybe they don't get used much or at all.)

Bob

#5 lore raw
Quoted 4 lines · Zhijian Li (Fujitsu)

Yanjun,

Quoted 1 line · Zhu Yanjun

在 2023/9/14 4:50, Bob Pearson 写道:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Li,

I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,

I made tests for many times about adding newline speeding up flush messages. With or without new line, I can not find out the difference on flushing messages. Not sure if Li Zhijian found this difference in a specific scenario or not. And even without new line, after output the line, the message still goes to a new line. I suspect if a newline is appended in the PRINTK subsystem.

When i'm using something like: dmesg --follow monitor the dmesg, I can notice that delay clearly. you will see that the timestamp is correct, but the messages don't appear until a next newline.

Thanks. To verify what you said, I made a simple tests. In my test, I output logs with several printk lines without newlines.

From the test result, except the last printk line, the other printk lines can output logs correctly in time.

Perhaps kernel standards add newlines in the format strings. And the last printk without newlines can not output logs in time.

To fix this problem, I add a newline in the last printk line. Then all the printk logs can output correctly in time.

I think your commit and Bob's commit have added newlines in RXE.

Thanks.

Zhu Yanjun

Quoted 12 lines

Thanks
Zhijian

Quoted 6 lines

Zhu Yanjun

Quoted 4 lines

for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent and make them all the same. (Maybe they don't get used much or at all.)

Bob