Skip to contentSkip to conversation

lvm-tools patches

linux-lvm Applied Ragnar Kjørstad 2 participants 2 messages Apr 19, 2000

lore
Share & tools
lore
#0 lore raw

Hi

I've attached a few small patches for lvm-tools (0.8final).

* lvm-compile.patch changes gnu/types.h to sys/types.h - it would not compile without this change. (On RH 6.2)
* lvm-lvdisplay fixes a bug that made it impossible to use "-v -v".
* lvm-pvmove removes the source-PV equals dest-PV test. I can't see any reason for this - I want to be able to move my PEs around on the same disk....

Signature · 1 line
Ragnar Kj�rstad
0.8final/tools/lib/liblvm.h renamed from 0.8final.orig/tools/lib/liblvm.h +1 -1
@@ -47,7 +47,7 @@
 #  include <linux/version.h>
 #endif
 
-#include <gnu/types.h>
+#include <sys/types.h>
 
 #include <sys/stat.h>
 
0.8final/tools/lvdisplay.c renamed from 0.8final.orig/tools/lvdisplay.c +1 -1
@@ -149,7 +149,7 @@
       return LVM_ELVDISPLAY_LV_MISSING;
    }
 
-   if ( opt_c + opt_v > 1) {
+   if ( opt_c && opt_v ) {
       fprintf ( stderr, "%s -- option v not allowed with option c\n\n", cmd);
       return LVM_ELVDISPLAY_LV_MISSING;
    }
0.8final/tools/pvmove.c renamed from 0.8final.orig/tools/pvmove.c +0 -7
@@ -292,13 +292,6 @@
       return LVM_EPVMOVE_VG_CHECK_CONSISTENCY;
    }
 
-   if ( vg->pv_cur == 1) {
-      fprintf ( stderr, "%s -- volume group \"%s\" only has 1 "
-                        "physical volume\n\n",
-                        cmd, vg_name);
-      return LVM_EPVMOVE_PV_CUR;
-   }
-
    /* get index of source physical volume */
    if ( opt_v > 0) printf ( "%s -- searching for source physical volume \"%s\" "
                             "in volume group \"%s\"\n",
#1 lore raw

Applied.

Regards,
Heinz

Quoted 15 lines

Hi

I've attached a few small patches for lvm-tools (0.8final).

* lvm-compile.patch changes gnu/types.h to sys/types.h - it would not compile without this change. (On RH 6.2)
* lvm-lvdisplay fixes a bug that made it impossible to use "-v -v".
* lvm-pvmove removes the source-PV equals dest-PV test. I can't see any reason for this - I want to be able to move my PEs around on the same disk....

Signature · 1 line
Ragnar Kjørstad

[Attachment, skipping...]

[Attachment, skipping...]

[Attachment, skipping...]

Signature · 11 lines
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Systemmanagement TS                              T-Nova
                                                 Entwicklungszentrum Darmstadt
Heinz Mauelshagen                                Otto-Roehm-Strasse 71c
Senior Systems Engineer                          Postfach 10 05 41
                                                 64205 Darmstadt
[email protected]                      Germany
                                                 +49 6151 886-425
                                                          FAX-386
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-