Fix error code when read()ing directories in /proc

PATCH New Matt Kraai 1 participant 1 message Nov 23, 2000 Proc filesystem

lore

Share & tools

lore

Matt Kraai

author

2000-11-23 17:33 UTC #0 lore raw

PATCH 1/1 Fix error code when read()ing directories in /proc

Howdy,

Calling read() on some directories in /proc returns EINVAL, rather than EISDIR. The other filesystems return EISDIR and the manpage says this is what should be returned in this situation. The appended patch applies against 2.4.0-test11.

Matt

fs/proc/generic.c +1 -0

diff -urN linux-vanilla/fs/proc/generic.c linux/fs/proc/generic.c
@@ -336,6 +336,7 @@
  * the /proc directory.
  */
 static struct file_operations proc_dir_operations = {
+	read:			generic_read_dir,
 	readdir:		proc_readdir,
 };

fs/proc/root.c +1 -0

diff -urN linux-vanilla/fs/proc/root.c linux/fs/proc/root.c
@@ -82,6 +82,7 @@
  * directory handling functions for that..
  */
 static struct file_operations proc_root_operations = {
+	read:		 generic_read_dir,
 	readdir:	 proc_root_readdir,
 };

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/