driver/net/Makefile bug (pcmcia)

modules for pcmcia network cards are not build by the kernel.

subdir-$(CONFIG_PCMCIA) += pcmcia

should be

ifeq ($(CONFIG_PCMCIA),y)
subdir-y += pcmcia
subdir-m += pcmcia
endif

because CONFIG_PCMCIA=y but CONFIG_PCMCIA_SOMENETWORKDRIVER=m maybe even bett is useing CONFIG_NET_PCMCIA instead of CONFIG_PCMCIA.

regards, andreas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

I just tried, and I don't see this problem. What's your .config?

No, pcmcia is in $(mod-subdirs), which leads to "make" entering drivers/net/pcmcia when MAKING_MODULES, even if pcmcia is only in $(subdir-y).

BTW: CONFIG_PCMCIA is a tristate, so the above would break CONFIG_PCMCIA=m.

Yes, that makes sense to me.
Proposed patch:

diff -ur linux-2.4.0-prerelease-diff/drivers/net/Makefile linux-2.4.0-prerelease-diff.work/drivers/net/Makefile
@@ -26,7 +26,7 @@
   obj-$(CONFIG_ISDN) += slhc.o
 endif
 
-subdir-$(CONFIG_PCMCIA) += pcmcia
+subdir-$(CONFIG_NET_PCMCIA) += pcmcia
 subdir-$(CONFIG_TULIP) += tulip
 subdir-$(CONFIG_IRDA) += irda
 subdir-$(CONFIG_TR) += tokenring

[This doesn't fix any bugs, but it slightly optimizes the build process because drivers/net/pcmcia will only be entered when PCMCIA net drivers are selected]

--Kai

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/