Skip to contentSkip to conversation

Module section warning

DISCUSSION J . A . Magallon 3 participants 3 messages Jan 5, 2001 – Jan 6, 2001

lore
Share & tools
lore
#0 lore raw

Hi everyone.

As linux-2.4.0/Documentation/canges says, you need:

o  binutils               2.9.1.0.25              # ld -v
o  modutils               2.4.0                   # insmod -V

and 2.4 uses gas instead of as86 for real mode.

Are not that versions enough to delete the

__asm__(".section .modinfo\n\t.previous");

in module.h ?

--

J.A. Magallon $> cd pub
mailto:[email protected] $> more beer

Linux werewolf 2.2.19-pre6 #1 SMP Wed Jan 3 21:28:10 CET 2001 i686

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 8 lines
o  binutils               2.9.1.0.25              # ld -v
o  modutils               2.4.0                   # insmod -V

and 2.4 uses gas instead of as86 for real mode.

Are not that versions enough to delete the
__asm__(".section .modinfo\n\t.previous");
in module.h ?

Firstly they are guidelines for x86. Secondly certain configs need the updates so its pretty invasive to force it yet - 2.5.0 yes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 11 lines · Alan Cox
Quoted 8 lines
o  binutils               2.9.1.0.25              # ld -v
o  modutils               2.4.0                   # insmod -V

and 2.4 uses gas instead of as86 for real mode.

Are not that versions enough to delete the
__asm__(".section .modinfo\n\t.previous");
in module.h ?

Firstly they are guidelines for x86. Secondly certain configs need the updates so its pretty invasive to force it yet - 2.5.0 yes

Any modutils >= 2.3.19 automatically treats .modinfo as no load, irrespective of what the kernel says. Since modutils 2.3.21 fixes the local root exploit on modprobe, nobody on kernel 2.4 should be running modutils < 2.3.21. I am tempted to put a check in modules_install to detect insecure modutils and bitch.

Modutils 2.4 is backwards compatible down to 2.0 kernels. I have no qualms about removing __asm__(".section .modinfo\n\t.previous"); from module.h in 2.4 kernels and will be sending in patches to do that, along with other changes to module.h. Worst case when omitting that line and still using old modutils is a slightly larger module in memory.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/