Skip to contentSkip to conversation

CPP ## string concatination is for the token

PATCH New NIIBE Yutaka 1 participant 1 message Jan 13, 2001 PCI

lore
Share & tools
lore

NIIBE Yutaka

author
#0 lore raw

PATCH 1/1 CPP ## string concatination is for the token

I think that `##' operator for string concatination produces the token.

In pci.h, we have bogus ##' operator which doesn't produce valid token. We don't need (must not) have ## between s' and the open paren.

Here's the patch.

include/linux/pci.h +2 -2
diff -ruN v2.4.1-pre3/include/linux/pci.h linux/include/linux/pci.h
@@ -565,9 +565,9 @@
 { 	return PCIBIOS_DEVICE_NOT_FOUND; }
 
 #define _PCI_NOP(o,s,t) \
-	static inline int pcibios_##o##_config_##s## (u8 bus, u8 dfn, u8 where, t val) \
+	static inline int pcibios_##o##_config_##s (u8 bus, u8 dfn, u8 where, t val) \
 		{ return PCIBIOS_FUNC_NOT_SUPPORTED; } \
-	static inline int pci_##o##_config_##s## (struct pci_dev *dev, int where, t val) \
+	static inline int pci_##o##_config_##s (struct pci_dev *dev, int where, t val) \
 		{ return PCIBIOS_FUNC_NOT_SUPPORTED; }
 #define _PCI_NOP_ALL(o,x)	_PCI_NOP(o,byte,u8 x) \
 				_PCI_NOP(o,word,u16 x) \
Signature · 4 lines
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/