Skip to contentSkip to conversation

2.4.2: irq-driven lp stalls

PATCH New Tim Waugh 1 participant 1 message Feb 27, 2001 Parallel port

lore
Share & tools
lore

Tim Waugh

author
#0 lore raw

PATCH 1/1 2.4.2: irq-driven lp stalls

Hi Linus,

This patch seems to cure some printing stalls that some people have been seeing. The down_trylock call isn't really needed there anyway.

Please apply.

Tim.
*/

2001-02-27 Tim Waugh <[email protected]>

* drivers/parport/ieee1284_ops.c: Remove down_trylock call, which seems to prevent stalls.
* drivers/parport/ChangeLog: Updated.

drivers/parport/ieee1284_ops.c renamed from drivers/parport/ieee1284_ops.c.sema +0 -3
@@ -50,9 +50,6 @@
 	if (port->irq != PARPORT_IRQ_NONE) {
 		parport_enable_irq (port);
 		no_irq = 0;
-
-		/* Clear out previous irqs. */
-		while (!down_trylock (&port->physport->ieee1284.irq));
 	}
 
 	port->physport->ieee1284.phase = IEEE1284_PH_FWD_DATA;
drivers/parport/ChangeLog renamed from drivers/parport/ChangeLog.sema +7 -0
@@ -0,0 +1,7 @@
+2001-02-27  Tim Waugh  <[email protected]>
+
+	* ieee1284_ops.c (parport_ieee1284_write_compat): Don't use
+	down_trylock to reset the IRQ count.  Don't even use sema_init,
+	because it's not even necessary to reset the count.  I can't
+	remember why we ever did.
+