Skip to contentSkip to conversation

fat problem in 2.4.2

PATCH Alexander Viro 1 participant 1 message Mar 1, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 9 lines · Linus Torvalds

In article <[email protected]>,

Quoted 7 lines · Alexander Viro

Alan, fix is really quite simple. Especially if you have vmtruncate() returning int (ac1 used to do it, I didn't check later ones). Actually just a generic_cont_expand() done on expanding path in vmtruncate() will be enough - it should be OK for all cases, including normal filesystems. <grabbing -ac7>

Quoted 5 lines
Quoted 1 line

OK, any brave soul to test that? All I can promise that it builds.

This looks like it would create a dummy block even for non-broken filesystems (ie truncating a file to be larger on ext2 would create a block, no?). While that would work, it would also waste disk-space.

<checking> yeah... Frankly, I'd just do

buffer.c.old renamed from buffer.c +8 -0
@@ -1571,6 +1571,9 @@
 	struct buffer_head *bh, *head, *wait[2], **wait_bh=wait;
 	char *kaddr = kmap(page);
 
+	if (from >= to)
+		goto done;
+
 	blocksize = inode->i_sb->s_blocksize;
 	if (!page->buffers)
 		create_empty_buffers(page, inode->i_dev, blocksize);
@@ -1626,6 +1629,7 @@
 		if (!buffer_uptodate(*wait_bh))
 			goto out;
 	}
+done:
 	return 0;
 out:
 	bh = head;
@@ -1648,6 +1652,9 @@
 	unsigned blocksize;
 	struct buffer_head *bh, *head;
 
+	if (from >= to)
+		goto done;
+
 	blocksize = inode->i_sb->s_blocksize;
 
 	for(bh = head = page->buffers, block_start = 0;
@@ -1677,6 +1684,7 @@
 	 */
 	if (!partial)
 		SetPageUptodate(page);
+done:
 	return 0;
 }
 

- obviously correct, avoids disk waste and since we do it in __block... everything keeps working (block_... versions are obviously OK, cont_... also does the right thing).

Dunno. I like the idea of expanding truncate() being the same as lseek() + empty write(). After all, that's what it is.

Comments?
Cheers,
Al