Skip to contentSkip to conversation

VMware 2.0.3 & Kernel 2.4.2-ac17

DISCUSSION Petr Vandrovec 1 participant 1 message Mar 12, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines

While compiling the vmnet module, there is a warning

make: Entering directory /tmp/vmware-config2/vmnet-only' bridge.c: In function VNetBridgeReceiveFromDev':
bridge.c:788: warning: implicit declaration of function `skb_datarefp'

Quoted 6 lines

and while inserting the module

/tmp/vmware-config2/vmnet.o: unresolved symbol skb_datarefp

I have traced this back to 2.4.2-ac4 by looking for where this function was removed.

Try this patch. I believe that there are no other needed changes in vmnet code, but as I do not have any scatter-gather checksumming hardware around, I'm not 100% sure. But up to now nobody complained about getting 'xxx invoked with paged skb', so I believe that rest of code is correct.

vnetInt.h +9 -3
diff -u vmnet-only.dist/vnetInt.h vmnet-only/vnetInt.h
@@ -16,9 +16,15 @@
 #  define KFREE_SKB(skb, type)		kfree_skb(skb)
 #  define DEV_KFREE_SKB(skb, type)	dev_kfree_skb(skb)
 #  define SKB_INCREF(skb)		atomic_inc(&(skb)->users)
-#  define SKB_IS_CLONE_OF(clone, skb)	( \
-      skb_datarefp(clone) == skb_datarefp(skb) \
-   )
+#  ifdef skb_shinfo
+#    define SKB_IS_CLONE_OF(clone, skb)	( \
+        skb_shinfo(clone) == skb_shinfo(skb) \
+     )
+#  else
+#    define SKB_IS_CLONE_OF(clone, skb)	( \
+        skb_datarefp(clone) == skb_datarefp(skb) \
+     )
+#  endif
 #  define SK_ALLOC(pri)			sk_alloc(0, pri, 1)
 #  define DEV_QUEUE_XMIT(skb, dev, pri)	( \
       (skb)->dev = (dev), \
Quoted 2 lines

yes, technically this probably is OT, and properly belong on the VMware list, but I can't access their nntp server.

Is problem on your side or on VMware side? If on VMware one, I'd like to know (private pls.).
Best regards,
Petr Vandrovec [email protected]