Skip to contentSkip to conversation

rwsem.o listed twice as export-objs

PATCH Ingo Oeser 2 participants 4 messages Apr 20, 2001 – Apr 22, 2001

Subsystems (2)
Kbuild Library code
lore
Share & tools
lore

Ingo Oeser

author
#0 lore raw

Hi David,

please remove rwsem.o from the list of exported objects, if it is not used.

Regards

Ingo Oeser

patch is as follows

Makefile Fri Apr 20 21:51:19 2001 renamed from Makefile.orig Fri Apr 20 21:51:12 2001 +1 -1
@@ -8,7 +8,7 @@
 
 L_TARGET := lib.a
 
-export-objs := cmdline.o rwsem.o
+export-objs := cmdline.o
 
 obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o bust_spinlocks.o
Signature · 2 lines
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
#1 lore raw
Quoted 4 lines · In article <[email protected]> you wrote:

Hi David,

please remove rwsem.o from the list of exported objects, if it is not used.

No! The whole point of 'export-objs' is to _always_ list the objects there to make the makefiles smaller and cleaner.

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.
author
#2 lore raw
In reply to Ingo Oeser
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · In article <[email protected]> you wrote:

please remove rwsem.o from the list of exported objects, if it is not used.

No! The whole point of 'export-objs' is to _always_ list the objects there to make the makefiles smaller and cleaner.

Ok, so this patch is better?

lib/Makefile Sat Apr 21 20:14:37 2001 renamed from lib/Makefile.orig Sat Apr 21 20:15:00 2001 +0 -1
@@ -8,12 +8,11 @@
 
 L_TARGET := lib.a
 
 export-objs := cmdline.o rwsem.o
 
 obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o bust_spinlocks.o
 
 ifneq ($(CONFIG_RWSEM_GENERIC_SPINLOCK)$(CONFIG_RWSEM_XCHGADD_ALGORITHM),nn)
-export-objs += rwsem.o
 obj-y += rwsem.o
 endif

Because any of the solutions should be applied, because rwsem.o is listed twice currently, which gives a warning at compile time.

Regards

Ingo Oeser

Signature · 2 lines
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
#3 lore raw
In reply to Ingo Oeser
Quoted 9 lines · Ingo Oeser
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · In article <[email protected]> you wrote:

please remove rwsem.o from the list of exported objects, if it is not used.

No! The whole point of 'export-objs' is to _always_ list the objects there to make the makefiles smaller and cleaner.

Ok, so this patch is better?

Yes.

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.