Skip to contentSkip to conversation

disable_ide_dma gcc-3.0 warn

DISCUSSION J . A . Magallon 3 participants 3 messages Apr 23, 2001

lore
Share & tools
lore

J . A . Magallon

author
#0 lore raw

Hi, everyone.

One other gcc-3.0 warning (apart from the classic multiline strings) I do not know if it can be important.

gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-ac12/include -Wall -Wstrict-prototypes - O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2
-march=i686 -c -o dmi_scan.o dmi_scan.c
dmi_scan.c:158: warning: `disable_ide_dma' defined but not used

In dmi_scan.c there is the func:
static __init int disable_ide_dma(struct dmi_blacklist *d)

But now it is unused (intentionally ?):

static __initdata struct dmi_blacklist dmi_blacklist[]={
#if 0 <==================
{ disable_ide_dma, "KT7", { /* Overbroad right now - kill DMA on problem KT7
boards */

            MATCH(DMI_PRODUCT_NAME, "KT7-RAID"),
            NO_MATCH, NO_MATCH, NO_MATCH
            } },
#endif  
    { broken_apm_power, "Dell Inspiron 5000e", {    /* Handle problems with APM
on Inspiron 5000e */
            MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
            MATCH(DMI_BIOS_VERSION, "A04"),
            MATCH(DMI_BIOS_DATE, "08/24/2000"), NO_MATCH
            } },
    { NULL, }
};
Signature · 4 lines
J.A. Magallon                                          #  Let the source
mailto:[email protected]                              #  be with you, Luke... 

Linux werewolf 2.4.3-ac12 #1 SMP Sun Apr 22 10:27:22 CEST 2001 i686
#1 lore raw
Quoted 5 lines · J . A . Magallon

In dmi_scan.c there is the func:
static __init int disable_ide_dma(struct dmi_blacklist *d)

But now it is unused (intentionally ?):

Quoted 8 lines

static __initdata struct dmi_blacklist dmi_blacklist[]={
#if 0 <==================
{ disable_ide_dma, "KT7", { /* Overbroad right now - kill DMA on problem KT7
boards */

            MATCH(DMI_PRODUCT_NAME, "KT7-RAID"),
            NO_MATCH, NO_MATCH, NO_MATCH
            } },

#endif

I guess this is a leftover from the VIA buggy southbridge workaround hunt.

Code marked with "#if 0" and "#if 1" is usally under development and subject to changes.

Or left intentionally in "#if 0" to show the reader that we had an wrong idea once, which seemed to be obviously correct (may be from the docs) and we solved it with a different method, which is not obvious or even not stated in the docs, but is the right one.

So we avoid stupid patches by leaving such things for reference.

In short: Don't care about new dead code too much, if it will be
needed by a "#if 0" marked code section.

BTW: Which revision of gcc 3.0 do you use? I had no luck compiling
it yet. Please answer in private to gcc issues.

Regards

Ingo Oeser

Signature · 2 lines
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
#2 lore raw
In reply to J . A . Magallon
Quoted 7 lines

-march=i686 -c -o dmi_scan.o dmi_scan.c
dmi_scan.c:158: warning: `disable_ide_dma' defined but not used

In dmi_scan.c there is the func:
static __init int disable_ide_dma(struct dmi_blacklist *d)

But now it is unused (intentionally ?):

Intentionally for now