Skip to contentSkip to conversation

tty kill character handling problems

PATCH Taral 1 participant 1 message May 12, 2001 Char and misc drivers

lore
Share & tools
lore

Taral

author
#0 lore raw

I think the current echok/echoke/echoe handling is wrong. The following patch should fix the problem, unless I've totally misunderstood this...

drivers/char/n_tty.c renamed from drivers/char/n_tty.c.orig +1 -1
@@ -352,7 +352,7 @@
 			spin_unlock_irqrestore(&tty->read_lock, flags);
 			return;
 		}
-		if (!L_ECHOK(tty) || !L_ECHOKE(tty) || !L_ECHOE(tty)) {
+		if (!L_ECHOKE(tty)) {
 			spin_lock_irqsave(&tty->read_lock, flags);
 			tty->read_cnt -= ((tty->read_head - tty->canon_head) &
 					  (N_TTY_BUF_SIZE - 1));
Signature · 4 lines
Taral <[email protected]>
Please use PGP/GPG encryption to send me mail.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose