Skip to contentSkip to conversation

acpi patch in 2.4.6

PATCH Arjan van de Ven 2 participants 2 messages Jul 18, 2001 ACPI

lore
Share & tools
lore

Arjan van de Ven

author
#0 lore raw

Hi,

How is the following chunk taken from patch-2.4.6 ever going to work ?

diff -u --recursive --new-file v2.4.5/linux/drivers/acpi/os.c linux/drivers/acpi/os.c

drivers/acpi/os.c Sun Jun 24 20:53:07 2001 renamed from linux/drivers/acpi/os.c Mon Jan 22 13:23:43 2001 +1 -1
@@ -248,27 +293,27 @@
 void
 acpi_os_mem_out8 (ACPI_PHYSICAL_ADDRESS phys_addr, UINT8 value)
 {
-       *(u8*) (u32) phys_addr = value;
+       *(u8*) phys_to_virt(phys_addr) = value;
 }
#1 lore raw
Quoted 2 lines · Arjan van de Ven

How is the following chunk taken from patch-2.4.6 ever going to work ?

Because ACPI physical addresses are _physical_ memory addresses, and we have a 1:1 mapping for most of them (notably the BIOS extended areas).

Linus