Kernel diff_small_2.4.8pre2_2.4.8pre3

DISCUSSION Andrea Arcangeli 1 participant 1 message Jul 31, 2001 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andrea Arcangeli

author

2001-07-31 03:58 UTC #1 lore raw

include/asm-i386/softirq.h line 33

Quoted 12 lines · Andrea Arcangeli

diff -urN 2.4.8pre2/include/asm-i386/softirq.h 2.4.8pre3/include/asm-i386/softirq.h

include/asm-i386/softirq.h +0 -2

@@ -28,8 +28,6 @@
 	unsigned long flags;						\
 									\
 	__save_flags(flags);						\
-	if (!(flags & (1 << 9)))					\
-		BUG();							\
 	barrier();							\
 	if (!--*ptr)							\
 		__asm__ __volatile__ (					\

if you drop the bugcheck you should drop the __save_flags and flags too.

What was the problem with it? I seen a report from Chris but that sounds like a bug in a caller of the the smp-call function (smp-call must be run with irq enabled as it's written explicitly in the comment on top of it).

Andrea