another vxfs fix

semiPATCH Christoph Hellwig 1 participant 1 message Aug 3, 2001 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Christoph Hellwig

author

2001-08-03 07:58 UTC #1 lore raw

Quoted 13 lines · On Fri, Aug 03, 2001 at 12:43:48AM +0000, [email protected] wrote:

With the brelse() fix, a failed vxfs mount is OK.
But after a successful vxfs mount the umount still yields
VFS: Busy inodes after unmount. Self-destruct in 5 seconds. Have a nice day
(And today's [yesterday's] patch by Christoph makes no difference.)
The reason is that the routine vxfs_fake_inode() does new_inode(), but this inode is never returned.
I fixed this but am not sure against which base source the patch should be described.
A minimal version would be to change the six [1] calls of
vxfs_put_inode()
in vxfs_super.c into calls of

Quoted 4 lines

	iput()
(In my source I turned vxfs_fake_inode() into vxfs_get_fake_inode() and added vxfs_put_fake_inode() that just does iput().)

Sounds fine - just submit me any version and I'll rebase it against the latest Linus and Alan trees.

Christoph

Signature · 1 line

Of course it doesn't work. We've performed a software upgrade.